Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Plain View
Sqoop, mail # dev - Review Request 12694: SQOOP-1139:  Fix code style


+
Venkat Ranganathan 2013-07-17, 17:25
Copy link to this message
-
Re: Review Request 12694: SQOOP-1139:  Fix code style
Jarek Cecho 2013-07-17, 17:36

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12694/#review23305
-----------------------------------------------------------
Thank you for taking this up Venkat! I've noticed that some of the longer lines were splitted into two lines and I was wondering if that was intentional change or some "auto-editing" tool? Otherwise please just remove the trailing whitespace characters:
core/src/main/java/org/apache/sqoop/framework/JobManager.java
<https://reviews.apache.org/r/12694/#comment47183>

    Nit: Trailing white space character.

core/src/main/java/org/apache/sqoop/framework/JobManager.java
<https://reviews.apache.org/r/12694/#comment47184>

    Nit: Trailing white space character.

core/src/main/java/org/apache/sqoop/framework/JobManager.java
<https://reviews.apache.org/r/12694/#comment47185>

    Nit: Trailing white space character.

core/src/main/java/org/apache/sqoop/framework/JobManager.java
<https://reviews.apache.org/r/12694/#comment47186>

    Nit: Trailing white space character.

core/src/main/java/org/apache/sqoop/framework/JobManager.java
<https://reviews.apache.org/r/12694/#comment47187>

    Nit: Trailing white space character.

core/src/main/java/org/apache/sqoop/framework/JobManager.java
<https://reviews.apache.org/r/12694/#comment47188>

    Nit: Trailing white space character.

core/src/main/java/org/apache/sqoop/framework/JobManager.java
<https://reviews.apache.org/r/12694/#comment47189>

    Nit: Trailing white space character.
Jarcec

- Jarek Cecho
On July 17, 2013, 5:25 p.m., Venkat Ranganathan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12694/
> -----------------------------------------------------------
>
> (Updated July 17, 2013, 5:25 p.m.)
>
>
> Review request for Sqoop.
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> Fixed code style to match rest of the code
>
>
> Diffs
> -----
>
>   core/src/main/java/org/apache/sqoop/framework/JobManager.java 2d37020
>
> Diff: https://reviews.apache.org/r/12694/diff/
>
>
> Testing
> -------
>
> Ran tests - All of them passed
>
>
> Thanks,
>
> Venkat Ranganathan
>
>

+
Venkat Ranganathan 2013-07-17, 18:46
+
Venkat Ranganathan 2013-07-17, 18:47
+
Jarek Cecho 2013-07-17, 21:32