Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Plain View
Sqoop >> mail # dev >> Review Request:  Sqoop2: Introduce synchronous job submission to Client API


+
rj.vasanthkumar@... 2013-04-30, 19:56
+
Jarek Cecho 2013-05-02, 00:49
+
rj.vasanthkumar@... 2013-05-02, 14:43
+
Jarek Cecho 2013-05-03, 05:08
+
rj.vasanthkumar@... 2013-05-03, 13:18
+
rj.vasanthkumar@... 2013-05-03, 20:31
+
rj.vasanthkumar@... 2013-05-03, 22:14
+
Jarek Cecho 2013-05-20, 13:59
+
Jarek Cecho 2013-05-03, 21:05
Copy link to this message
-
Re: Review Request: Sqoop2: Introduce synchronous job submission to Client API

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10869/#review20116
-----------------------------------------------------------
Hi Vasanth,
thank you very much for incorporating my suggestions. I do have couple of notes:
client/src/main/java/org/apache/sqoop/client/SqoopClient.java
<https://reviews.apache.org/r/10869/#comment41364>

    Can we introduce new error code explaining that the poll time can't be negative?

client/src/main/java/org/apache/sqoop/client/SqoopClient.java
<https://reviews.apache.org/r/10869/#comment41365>

    I think that returning immediately will change the behaviour of this method from synchronous to asynchronous, which might be quite confusing for our users. What about just calling the callbacks if the object is not null? This way the method will still be synchronous but the callbacks will be still optional.

client/src/main/java/org/apache/sqoop/client/SubmissionCallback.java
<https://reviews.apache.org/r/10869/#comment41366>

    I was thinking a bit about the callback interface and I think that it would be useful to have it more powerful. What about introducing following method?
    
    * submitted(MSubmission)
    * updated(MSubmission)
    * finished(MSubmission)
Jarcec

- Jarek Cecho
On May 3, 2013, 1:18 p.m., vasanthkumar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10869/
> -----------------------------------------------------------
>
> (Updated May 3, 2013, 1:18 p.m.)
>
>
> Review request for Sqoop.
>
>
> Description
> -------
>
> Synchronous job submission to Client API.
>
>
> This addresses bug SQOOP-985.
>     https://issues.apache.org/jira/browse/SQOOP-985
>
>
> Diffs
> -----
>
>   client/src/main/java/org/apache/sqoop/client/SqoopClient.java f9137bb
>   client/src/main/java/org/apache/sqoop/client/SubmissionCallback.java PRE-CREATION
>   client/src/main/java/org/apache/sqoop/client/shell/SubmissionStartFunction.java f68ac11
>
> Diff: https://reviews.apache.org/r/10869/diff/
>
>
> Testing
> -------
>
> Done
>
>
> Thanks,
>
> vasanthkumar
>
>