Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Hive >> mail # dev >> Review Request 12133: HIVE-4786 Incorrect aggregate results


Copy link to this message
-
Review Request 12133: HIVE-4786 Incorrect aggregate results

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12133/
-----------------------------------------------------------

Review request for hive, Eric Hanson and Jitendra Pandey.
Bugs: HIVE-4786
    https://issues.apache.org/jira/browse/HIVE-4786
Repository: hive-git
Description
-------

AVG needs to use double to aggregate the sum part
All VARIANCE aggregates need to use double in the computation of the running sum and variance, ie. force cast from long vector values to double variable
Diffs
-----

  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/aggregates/gen/VectorUDAFAvgLong.java ff8ca5c
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/aggregates/gen/VectorUDAFStdPopLong.java 45a0018
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/aggregates/gen/VectorUDAFStdSampLong.java f854304
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/aggregates/gen/VectorUDAFVarPopLong.java 5e4f93b
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/aggregates/gen/VectorUDAFVarSampLong.java 593cd9b
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/templates/VectorUDAFAvg.txt 9629418
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/templates/VectorUDAFVar.txt 0f46d1a

Diff: https://reviews.apache.org/r/12133/diff/
Testing
-------

manually tested repro case
Thanks,

Remus Rusanu