Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Plain View
Sqoop >> mail # dev >> Review Request: Sqoop2: Move string constants from FormDisplayer to resource file


+
rj.vasanthkumar@... 2013-02-28, 03:04
+
rj.vasanthkumar@... 2013-03-11, 12:33
+
Jarek Cecho 2013-03-15, 04:59
Copy link to this message
-
Re: Review Request: Sqoop2: Move string constants from FormDisplayer to resource file

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9669/
-----------------------------------------------------------

(Updated March 15, 2013, 6:12 a.m.)
Review request for Sqoop.
Changes
-------

Hi Jarek,

Thank you for your review comments. Moved resource constants into client's constant class and patch updated.

vasanth
Description
-------

Move string constants from FormDisplayer to resource file
This addresses bug SQOOP-887.
    https://issues.apache.org/jira/browse/SQOOP-887
Diffs (updated)
-----

  client/src/main/java/org/apache/sqoop/client/core/Constants.java ae3f994
  client/src/main/java/org/apache/sqoop/client/shell/ShellEnvironment.java 8c133f2
  client/src/main/java/org/apache/sqoop/client/utils/FormDisplayer.java abd9643
  client/src/main/resources/client-resource.properties c3a22bb

Diff: https://reviews.apache.org/r/9669/diff/
Testing
-------

Done
Thanks,

vasanthkumar

+
Jarek Cecho 2013-03-15, 18:33
+
rj.vasanthkumar@... 2013-03-15, 19:47
+
Jarek Cecho 2013-03-11, 05:35
+
vasanth kumar 2013-03-11, 05:40