-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.hbase.org/r/338/#review429
-----------------------------------------------------------
It should probably be reindented before the patch is inserted as well.

- Alex
On 2010-07-20 08:49:14, Alex Newman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://review.hbase.org/r/338/
> -----------------------------------------------------------
>
> (Updated 2010-07-20 08:49:14)
>
>
> Review request for hbase and stack.
>
>
> Summary
> -------
>
> TestHLOG does a bunch of old style tests I like the new style ones better. I bet you do as well.
>
>
> Diffs
> -----
>
>   src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestHLog.java 211162e
>
> Diff: http://review.hbase.org/r/338/diff
>
>
> Testing
> -------
>
> I reran its tests.
>
>
> Thanks,
>
> Alex
>
>

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.hbase.org/r/339/
-----------------------------------------------------------

Review request for hbase and stack.
Summary
-------

TestHLOG does a bunch of old style tests I like the new style ones better. I bet you do as well.
Diffs
-----

  src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestHLog.java 211162e

Diff: http://review.hbase.org/r/339/diff
Testing
-------

I reran its tests.
Thanks,

Alex

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.hbase.org/r/339/#review430
-----------------------------------------------------------
It looks great Alex.  Fix the formatting.  Make it just like the others (e.g. tabs of two spaces) and remove the tabs you introduced.  Good on you.

- stack
On 2010-07-20 09:01:50, Alex Newman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://review.hbase.org/r/339/
> -----------------------------------------------------------
>
> (Updated 2010-07-20 09:01:50)
>
>
> Review request for hbase and stack.
>
>
> Summary
> -------
>
> TestHLOG does a bunch of old style tests I like the new style ones better. I bet you do as well.
>
>
> Diffs
> -----
>
>   src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestHLog.java 211162e
>
> Diff: http://review.hbase.org/r/339/diff
>
>
> Testing
> -------
>
> I reran its tests.
>
>
> Thanks,
>
> Alex
>
>

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.hbase.org/r/339/
-----------------------------------------------------------

(Updated 2010-07-20 10:06:59.088899)
Review request for hbase and stack.
Changes
-------

Ok i updated the diff weirdly rb doesn't show a difference but if you download it, it will
Summary (updated)
-------

TestHLOG does a bunch of old style tests I like the new style ones better. I bet you do as well. any suggestions on what I should do with the getname function?
Diffs (updated)
-----

  src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestHLog.java 211162e

Diff: http://review.hbase.org/r/339/diff
Testing
-------

I reran its tests.
Thanks,

Alex

> On 2010-07-20 09:36:51, stack wrote:
> > It looks great Alex.  Fix the formatting.  Make it just like the others (e.g. tabs of two spaces) and remove the tabs you introduced.  Good on you.

I click the 'Download Diff' and still see tabs:

E.g:

+^Ipublic void tearDown() throws Exception {$
- stack
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.hbase.org/r/339/#review430
-----------------------------------------------------------
On 2010-07-20 10:06:59, Alex Newman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://review.hbase.org/r/339/
> -----------------------------------------------------------
>
> (Updated 2010-07-20 10:06:59)
>
>
> Review request for hbase and stack.
>
>
> Summary
> -------
>
> TestHLOG does a bunch of old style tests I like the new style ones better. I bet you do as well. any suggestions on what I should do with the getname function?
>
>
> Diffs
> -----
>
>   src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestHLog.java 211162e
>
> Diff: http://review.hbase.org/r/339/diff
>
>
> Testing
> -------
>
> I reran its tests.
>
>
> Thanks,
>
> Alex
>
>

> On 2010-07-20 09:36:51, stack wrote:
> > It looks great Alex.  Fix the formatting.  Make it just like the others (e.g. tabs of two spaces) and remove the tabs you introduced.  Good on you.
>
> stack wrote:
>     I click the 'Download Diff' and still see tabs:
>    
>     E.g:
>    
>     +^Ipublic void tearDown() throws Exception {$

sorry i am a fail, lets see if that worked
- Alex
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.hbase.org/r/339/#review430
-----------------------------------------------------------
On 2010-07-20 10:49:11, Alex Newman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://review.hbase.org/r/339/
> -----------------------------------------------------------
>
> (Updated 2010-07-20 10:49:11)
>
>
> Review request for hbase and stack.
>
>
> Summary
> -------
>
> TestHLOG does a bunch of old style tests I like the new style ones better. I bet you do as well. any suggestions on what I should do with the getname function?
>
>
> Diffs
> -----
>
>   src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestHLog.java 211162e
>
> Diff: http://review.hbase.org/r/339/diff
>
>
> Testing
> -------
>
> I reran its tests.
>
>
> Thanks,
>
> Alex
>
>

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.hbase.org/r/339/
-----------------------------------------------------------

(Updated 2010-07-20 10:49:11.508282)
Review request for hbase and stack.
Changes
-------

ahh there she goes.
Summary
-------

TestHLOG does a bunch of old style tests I like the new style ones better. I bet you do as well. any suggestions on what I should do with the getname function?
Diffs (updated)
-----

  src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestHLog.java 211162e

Diff: http://review.hbase.org/r/339/diff
Testing
-------

I reran its tests.
Thanks,

Alex

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.hbase.org/r/339/#review436
-----------------------------------------------------------

Ship it!
+1

- stack
On 2010-07-20 10:49:11, Alex Newman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://review.hbase.org/r/339/
> -----------------------------------------------------------
>
> (Updated 2010-07-20 10:49:11)
>
>
> Review request for hbase and stack.
>
>
> Summary
> -------
>
> TestHLOG does a bunch of old style tests I like the new style ones better. I bet you do as well. any suggestions on what I should do with the getname function?
>
>
> Diffs
> -----
>
>   src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestHLog.java 211162e
>
> Diff: http://review.hbase.org/r/339/diff
>
>
> Testing
> -------
>
> I reran its tests.
>
>
> Thanks,
>
> Alex
>
>

> On 2010-07-20 20:35:37, stack wrote:
> > +1

Oh, there is no associated issue.  Open one please Alex so I can close it with the commit.  Attach this good patch to it (sorry for the overhead)
- stack
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.hbase.org/r/339/#review436
-----------------------------------------------------------
On 2010-07-20 10:49:11, Alex Newman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://review.hbase.org/r/339/
> -----------------------------------------------------------
>
> (Updated 2010-07-20 10:49:11)
>
>
> Review request for hbase and stack.
>
>
> Summary
> -------
>
> TestHLOG does a bunch of old style tests I like the new style ones better. I bet you do as well. any suggestions on what I should do with the getname function?
>
>
> Diffs
> -----
>
>   src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestHLog.java 211162e
>
> Diff: http://review.hbase.org/r/339/diff
>
>
> Testing
> -------
>
> I reran its tests.
>
>
> Thanks,
>
> Alex
>
>

> On 2010-07-20 20:35:37, stack wrote:
> > +1
>
> stack wrote:
>     Oh, there is no associated issue.  Open one please Alex so I can close it with the commit.  Attach this good patch to it (sorry for the overhead)

no worries i love filing jiras!
- Alex
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.hbase.org/r/339/#review436
-----------------------------------------------------------
On 2010-07-20 10:49:11, Alex Newman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://review.hbase.org/r/339/
> -----------------------------------------------------------
>
> (Updated 2010-07-20 10:49:11)
>
>
> Review request for hbase and stack.
>
>
> Summary
> -------
>
> TestHLOG does a bunch of old style tests I like the new style ones better. I bet you do as well. any suggestions on what I should do with the getname function?
>
>
> Diffs
> -----
>
>   src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestHLog.java 211162e
>
> Diff: http://review.hbase.org/r/339/diff
>
>
> Testing
> -------
>
> I reran its tests.
>
>
> Thanks,
>
> Alex
>
>