Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
HBase, mail # dev - Re: Review Request: Cleaned up TestHLog a bit


Copy link to this message
-
Re: Review Request: Cleaned up TestHLog a bit
Alex Newman 2010-07-20, 17:49


> On 2010-07-20 09:36:51, stack wrote:
> > It looks great Alex.  Fix the formatting.  Make it just like the others (e.g. tabs of two spaces) and remove the tabs you introduced.  Good on you.
>
> stack wrote:
>     I click the 'Download Diff' and still see tabs:
>    
>     E.g:
>    
>     +^Ipublic void tearDown() throws Exception {$

sorry i am a fail, lets see if that worked
- Alex
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.hbase.org/r/339/#review430
-----------------------------------------------------------
On 2010-07-20 10:49:11, Alex Newman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://review.hbase.org/r/339/
> -----------------------------------------------------------
>
> (Updated 2010-07-20 10:49:11)
>
>
> Review request for hbase and stack.
>
>
> Summary
> -------
>
> TestHLOG does a bunch of old style tests I like the new style ones better. I bet you do as well. any suggestions on what I should do with the getname function?
>
>
> Diffs
> -----
>
>   src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestHLog.java 211162e
>
> Diff: http://review.hbase.org/r/339/diff
>
>
> Testing
> -------
>
> I reran its tests.
>
>
> Thanks,
>
> Alex
>
>