Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Plain View
Sqoop, mail # dev - Review Request 15639: SQOOP-1236 Sqoop2: Sqoop2: Classpath generated by Submission enginue should contain only unique elements


+
Jarek Cecho 2013-11-18, 03:19
+
Jarek Cecho 2013-11-18, 16:04
Copy link to this message
-
Re: Review Request 15639: SQOOP-1236 Sqoop2: Sqoop2: Classpath generated by Submission enginue should contain only unique elements
Abraham Elmahrek 2013-11-27, 20:33

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15639/#review29503
-----------------------------------------------------------

Ship it!
Every thing looks great Jarcec. I left one comment below that isn't really critical. Feel free to include or ignore it as necessary. Thanks for your hard work!
core/src/test/java/org/apache/sqoop/framework/TestSubmissionRequest.java
<https://reviews.apache.org/r/15639/#comment56818>

    Validate order as well?
- Abraham Elmahrek
On Nov. 18, 2013, 4:04 p.m., Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15639/
> -----------------------------------------------------------
>
> (Updated Nov. 18, 2013, 4:04 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-1236
>     https://issues.apache.org/jira/browse/SQOOP-1236
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> Added code that will ensure that only unique entries will be present in the classpath. I've also used StringUtils.join() to merge all the entries for use (instead of home made version of the same).
>
>
> Diffs
> -----
>
>   core/src/main/java/org/apache/sqoop/framework/SubmissionRequest.java 53d003980a172e4e0acf18630a3496909c17cb5c
>   core/src/test/java/org/apache/sqoop/framework/TestSubmissionRequest.java PRE-CREATION
>   submission/mapreduce/src/main/java/org/apache/sqoop/submission/mapreduce/MapreduceSubmissionEngine.java 6fc485b66ea8c33d09d172675a104954d570f3a7
>
> Diff: https://reviews.apache.org/r/15639/diff/
>
>
> Testing
> -------
>
> Unit tests seems to be passing.
>
>
> Thanks,
>
> Jarek Cecho
>
>

+
Jarek Cecho 2013-12-02, 17:20
+
Jarek Cecho 2013-12-02, 17:21
+
Abraham Elmahrek 2013-12-02, 17:54
+
Abraham Elmahrek 2013-11-18, 13:21
+
Abraham Elmahrek 2013-11-18, 16:07
+
Jarek Cecho 2013-11-18, 16:03