Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Zookeeper, mail # dev - Review Request: ZOOKEEPER-1413: Use on-disk transaction log for learner sync up


Copy link to this message
-
Re: Review Request: ZOOKEEPER-1413: Use on-disk transaction log for learner sync up
fpj@... 2013-05-28, 21:08

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11231/#review21111
-----------------------------------------------------------

/src/java/main/org/apache/zookeeper/server/persistence/FileTxnSnapLog.java
<https://reviews.apache.org/r/11231/#comment43844>

    I think there is a read call in FileTxnLog, but not in FileTxnSnapLog. My recommendation is mostly because the read in FileTxnSnapLog could be both of the txn logs or snapshots. I don't think you would be renaming a method, but perhaps I'm not getting it right.  
- fpj
On May 20, 2013, 5:40 a.m., Thawan Kooburat wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11231/
> -----------------------------------------------------------
>
> (Updated May 20, 2013, 5:40 a.m.)
>
>
> Review request for zookeeper.
>
>
> Description
> -------
>
> ZOOKEEPER-1413: Use on-disk transaction log for learner sync up
>
> - Use txnlog for learner synchronization if learner fall too far behind
> - Refactoring LearnerHandler to deal with different cases of handling learner synchronization  
>
>
> This addresses bug https://issues.apache.org/jira/browse/ZOOKEEPER-1413.
>     https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/ZOOKEEPER-1413
>
>
> Diffs
> -----
>
>   /src/java/main/org/apache/zookeeper/server/TxnLogProposalIterator.java PRE-CREATION
>   /src/java/main/org/apache/zookeeper/server/ZKDatabase.java 1483440
>   /src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java 1483440
>   /src/java/main/org/apache/zookeeper/server/persistence/FileTxnSnapLog.java 1483440
>   /src/java/main/org/apache/zookeeper/server/persistence/TxnLog.java 1483440
>   /src/java/main/org/apache/zookeeper/server/quorum/LearnerHandler.java 1483440
>   /src/java/test/org/apache/zookeeper/server/quorum/LearnerHandlerTest.java PRE-CREATION
>   /src/java/test/org/apache/zookeeper/test/FollowerResyncConcurrencyTest.java 1483440
>   /src/java/test/org/apache/zookeeper/test/GetProposalFromTxnTest.java PRE-CREATION
>   /src/java/test/org/apache/zookeeper/test/LoadFromLogTest.java 1483440
>
> Diff: https://reviews.apache.org/r/11231/diff/
>
>
> Testing
> -------
>
> - unit tests
> - ran in prod for more than half a year
>
>
> Thanks,
>
> Thawan Kooburat
>
>