Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Accumulo >> mail # dev >> Review Request 23391: ACCUMULO-2986 ease use of rat plugin.


Copy link to this message
-
Re: Review Request 23391: ACCUMULO-2986 ease use of rat plugin.

The second patch looks good to me, regarding the profile, but I'm still concerned about the rat.ignoreErrors=true by default. I think that warrants further discussion on the mailing list, and I commented on the prior thread. So, I'm +1 to this profile arrangement, but -1 to rat.ignoreErrors=true. Do you want to split into two patches (the first without the rat.ignoreErrors property) and apply the first until consensus is reached on that issue? Because, I wouldn't object to that.
- Christopher
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23391/#review47614
On July 10, 2014, 6:10 p.m., Sean Busbey wrote: