Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Accumulo >> mail # dev >> [GitHub] accumulo pull request: ACCUMULO-2942 Fixes ShardedTableDistributio...

Copy link to this message
[GitHub] accumulo pull request: ACCUMULO-2944 Fixes harded coded Sun JVM in...
Github user busbey commented on a diff in the pull request:

    --- Diff: conf/templates/accumulo-env.sh ---
    @@ -51,10 +51,11 @@ test -z "$ACCUMULO_TSERVER_OPTS" && export ACCUMULO_TSERVER_OPTS="${POLICY} ${tS
     test -z "$ACCUMULO_MASTER_OPTS"  && export ACCUMULO_MASTER_OPTS="${POLICY} ${masterHigh_masterLow}"
     test -z "$ACCUMULO_MONITOR_OPTS" && export ACCUMULO_MONITOR_OPTS="${POLICY} ${monitorHigh_monitorLow}"
     test -z "$ACCUMULO_GC_OPTS"      && export ACCUMULO_GC_OPTS="${gcHigh_gcLow}"
    -test -z "$ACCUMULO_GENERAL_OPTS" && export ACCUMULO_GENERAL_OPTS="-XX:+UseConcMarkSweepGC -XX:CMSInitiatingOccupancyFraction=75 -Djava.net.preferIPv4Stack=true"
    +test -z "$ACCUMULO_GENERAL_OPTS" && export ACCUMULO_GENERAL_OPTS="${gcPolicy} -Djava.net.preferIPv4Stack=true ${jaxpDocBuilderFactory} ${randomNumGeneratorProviderOverride}"
     test -z "$ACCUMULO_OTHER_OPTS"   && export ACCUMULO_OTHER_OPTS="${otherHigh_otherLow}"
     # what do when the JVM runs out of heap memory
     export ACCUMULO_KILL_CMD='kill -9 %p'
    +export GC_POLICY_ARGS="${gcPolicy}"
    --- End diff --
    Yes, that sounds like a god idea.
    please either include the MiniAccumuloCluster change in this same patch, or move this environment variable to the patch taht includes said changes.
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [EMAIL PROTECTED] or file a JIRA ticket
with INFRA.