Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Accumulo >> mail # dev >> Review Request 17947: ACCUMULO-841 - refactor of randomwalk State


Copy link to this message
-
Re: Review Request 17947: ACCUMULO-841 - refactor of randomwalk State

This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17947/

(Updated Feb. 20, 2014, 9:41 a.m.)
Review request for accumulo.
Changes

Same as the last diff but renaming the RWEnvironment class to simply Environment, as Keith suggested.
Bugs: ACCUMULO-841
    https://issues.apache.org/jira/browse/ACCUMULO-841
Repository: accumulo
Description

This is a refactoring of the State class used for randomwalk. I tried to balance the extent of the refactoring with the extent of changes to the tests themselves. So, State is still a central class, but it delegates to other more focused classes for almost everything beyond storing just state key/value pairs. Other notes:

- The node visiting mechanism was unused so it's removed. Module has a maxHops counting mechanism which does the same thing.
- The getCredentials() method was only ever used to then get an authentication token, so the tests now get the token directly, and getCredentials() is gone.
Diffs (updated)

  test/src/main/java/org/apache/accumulo/test/randomwalk/Environment.java PRE-CREATION
  test/src/main/java/org/apache/accumulo/test/randomwalk/Fixture.java 73b51d25b3a1985d80fc6d2c61d4c7c0afd2442c
  test/src/main/java/org/apache/accumulo/test/randomwalk/Framework.java 9d0192938edd17d03431e4b2c144735bc059be1c
  test/src/main/java/org/apache/accumulo/test/randomwalk/Module.java 25684809daf29644550c05256c7abaf60fc2e75c
  test/src/main/java/org/apache/accumulo/test/randomwalk/Node.java 1868adedcbb41040d2b0e2e2edff642799f10673
  test/src/main/java/org/apache/accumulo/test/randomwalk/State.java f4102ab5dbff63e18ba5673126eeb5e646b84771
  test/src/main/java/org/apache/accumulo/test/randomwalk/bulk/BulkMinusOne.java 4ebf23f84aff2162e27c3c9de21bb4ec19e43949
  test/src/main/java/org/apache/accumulo/test/randomwalk/bulk/BulkPlusOne.java cdfbb3665cf87e94ff37363fdecd60481fabe1db
  test/src/main/java/org/apache/accumulo/test/randomwalk/bulk/BulkTest.java 4afefd98cad5819c2813180f54471917589d5953
  test/src/main/java/org/apache/accumulo/test/randomwalk/bulk/Compact.java 86dae5c9c4dbfb6809db0260b2911d2ad6705db7
  test/src/main/java/org/apache/accumulo/test/randomwalk/bulk/ConsistencyCheck.java e60f8cfe4bc9e3ad17b08a20f777c739031e8520
  test/src/main/java/org/apache/accumulo/test/randomwalk/bulk/Merge.java 2dd034595de60e4a7c910acaf70be96d7516c2a5
  test/src/main/java/org/apache/accumulo/test/randomwalk/bulk/Setup.java dad2bccb130f885f4c47646e0c4868a3c86a9fb4
  test/src/main/java/org/apache/accumulo/test/randomwalk/bulk/Split.java 157e2ab6ecdeb65193d074dc63fe76f4ae6ba0c0
  test/src/main/java/org/apache/accumulo/test/randomwalk/bulk/Verify.java b2299aa9ed174c8688ea13d47ddffd056d762c24
  test/src/main/java/org/apache/accumulo/test/randomwalk/concurrent/AddSplits.java e03b7f69c8b310184c330b3af134237d5ada466b
  test/src/main/java/org/apache/accumulo/test/randomwalk/concurrent/Apocalypse.java 252d52aebd055bdef748f35e3ce04702b968b5e8
  test/src/main/java/org/apache/accumulo/test/randomwalk/concurrent/BatchScan.java 3fa7d473b43460f5d1e51db4eff937cef8f980a2
  test/src/main/java/org/apache/accumulo/test/randomwalk/concurrent/BatchWrite.java f0022748499fb8e92fbf04a5693a19a64b5f9088
  test/src/main/java/org/apache/accumulo/test/randomwalk/concurrent/BulkImport.java d4d6838b1f26152378b3af554a00a3b17886ac98
  test/src/main/java/org/apache/accumulo/test/randomwalk/concurrent/ChangeAuthorizations.java b882a3a3ef1af9e2afa03aa6dd1a512b6fe3cd08
  test/src/main/java/org/apache/accumulo/test/randomwalk/concurrent/ChangePermissions.java 73e617595ad2d7afd0f050eb8ddc896b6066d0fe
  test/src/main/java/org/apache/accumulo/test/randomwalk/concurrent/CheckBalance.java 4cb0260cc129ea51c246ee69efdfbae46831d808
  test/src/main/java/org/apache/accumulo/test/randomwalk/concurrent/CheckPermission.java 50948b308b6a2fc38d607a76e4faad3aec6b9dac
  test/src/main/java/org/apache/accumulo/test/randomwalk/concurrent/CloneTable.java 780238584a50aad8c49cc6f4f4b21321b07b52b4
  test/src/main/java/org/apache/accumulo/test/randomwalk/concurrent/Compact.java d83055ac049ffcd2d32db93903f2ad25fc92dc87
  test/src/main/java/org/apache/accumulo/test/randomwalk/concurrent/ConcurrentFixture.java df7ddd76ad63d910f57ed5532142e2e8e57d343d
  test/src/main/java/org/apache/accumulo/test/randomwalk/concurrent/Config.java 402f13902f976b93ea36fadc2dd8af0c88f3a1de
  test/src/main/java/org/apache/accumulo/test/randomwalk/concurrent/CreateNamespace.java 43e6c0636d2d9f780b5c6490bf600f705d7b7466
  test/src/main/java/org/apache/accumulo/test/randomwalk/concurrent/CreateTable.java 21ae031776511c42845242a719bc52dc6d9ad072
  test/src/main/java/org/apache/accumulo/test/randomwalk/concurrent/CreateUser.java 24f25f3f36d89aacacc50423c8174003c984ce30
  test/src/main/java/org/apache/accumulo/test/randomwalk/concurrent/DeleteNamespace.java 333af3dfc27f2e1432a769c928c06b6996727bb0
  test/src/main/java/org/apache/accumulo/test/randomwalk/concurrent/DeleteRange.java 9b44782aae000d15c652e81df1d5c15a3ff5e006
  test/src/main/java/org/apache/accumulo/test/randomwalk/concurrent/DeleteTable.java 8adae6424b215879862a81e723a26e1b19475b2d
  test/src/main/java/org/apache/accumulo/test/randomwalk/concurrent/DropUser.java 672c4b8226895aff902ea71f3132d58d635c611d
  test/src/main/java/org/apache/accumulo/test/randomwalk/concurrent/IsolatedScan.java 905aa8e2fd604c176fbe85028040728d78fc5f4f
  test/src/main/java/org/apache/accumulo/test/randomwalk/concurrent/ListSplits.java 0f3d87fae3e74145e1c641e6c8ab3328237bfe1a
  test/src/main/java/org/apache/accumulo/test/randomwalk/concurrent/Merge.java a16f6a60d350c96e9a846f3586e08784a47dd5b5
  test/src/main/java/org/apache/accumulo/test/randomwalk/concurrent/OfflineTable.java c4d9babfe58f9df47e99d20f02b028a031774f3c
  test/src/main/java/org/apache/accumulo/test/randomwalk/concurrent/RenameNamespace.java 5aa21ed587721b2f5023d5c370dad9f891605643
  test/src/main/java/org/apache/accumulo/test/randomwalk/concurrent/RenameTable.java d9