Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Accumulo >> mail # dev >> Review Request 17947: ACCUMULO-841 - refactor of randomwalk State


Copy link to this message
-
Re: Review Request 17947: ACCUMULO-841 - refactor of randomwalk State

This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17947/#review34188

test/src/main/java/org/apache/accumulo/test/randomwalk/ConfigObjectManager.java
<https://reviews.apache.org/r/17947/#comment64200>

    Almost every class can be considered an ObjectManager.  Consider renaming the class ClientSideObjects or ClientObjects.

test/src/main/java/org/apache/accumulo/test/randomwalk/ConfigProperties.java
<https://reviews.apache.org/r/17947/#comment64202>

    The comment is wrong.  This class doesn't create objects: it can find the username and password.  Is it worth creating a whole class that just knows KEY_USERNAME and KEY_PASSWORD?

test/src/main/java/org/apache/accumulo/test/randomwalk/ConfigProperties.java
<https://reviews.apache.org/r/17947/#comment64203>

    The comment is wrong.  This class doesn't create objects: it can find the username and password.  Is it worth creating a whole class that just knows KEY_USERNAME and KEY_PASSWORD?

test/src/main/java/org/apache/accumulo/test/randomwalk/ConfigProperties.java
<https://reviews.apache.org/r/17947/#comment64201>

    Can we use the fancy guava class to check for preconditions?
- Eric Newton
On Feb. 11, 2014, 3:24 p.m., Bill Havanki wrote: