John Lee 2011-11-17, 16:58
Aaron T. Myers 2011-11-17, 18:00
John Lee 2011-11-17, 18:20
Aaron T. Myers 2011-11-17, 18:33
John Lee 2011-11-18, 20:54
Aaron T. Myers 2011-11-19, 00:19
Steve Loughran 2011-11-22, 11:24
On 17/11/11 18:00, Aaron T. Myers wrote:
> Hi John,
> If you're confident that the warnings are unrelated to the patch, just
> comment saying so on that JIRA and that will be fine.
> Aaron T. Myers
> Software Engineer, Cloudera
> On Thu, Nov 17, 2011 at 8:58 AM, John Lee<[EMAIL PROTECTED]> wrote:
>> I recently resubmitted a patch for
>> https://issues.apache.org/jira/browse/HADOOP-7021 and received -1
>> overall. When I took a look at what was the cause and it was due to
>> some findbugs warnings and javadoc warnings, which were unrelated to
>> the patch. Do these warnings need to be resolved before any new code
>> is committed to Hadoop Common?
findbugs can be false alarms; for the javadoc warnings I've found doing
the before and after javadoc runs myself into files and then diffing the
output the best way to be sure it isn't your fault.