Rohini Palaniswamy 2013-06-06, 01:21
-Re: Uploading patches for review
Jarek Jarcec Cecho 2013-06-06, 01:50
I can definitely recommend using the review board. We are using it already in all other projects that I'm participating and it's really helping us out.
On Wed, Jun 05, 2013 at 06:21:32PM -0700, Rohini Palaniswamy wrote:
> Reviewing uploaded patches for few lines of change is easy. But when
> the change is more it is hard to read, review is more time consuming and at
> times you have to switch between the patch and eclipse to get more context.
> Without the surrounding code it is also easy to miss things on review. Can
> we make it a practice and decide on putting up the patches in review board
> for review if it is slightly bigger? Commenting on the patch is also a
> breeze in the review board.
> Thoughts ???
Cheolsoo Park 2013-06-06, 06:53
Julien Le Dem 2013-06-06, 09:02
Alan Gates 2013-06-06, 09:25