Home | About | Sematext search-lucene.com search-hadoop.com
NEW: Monitor These Apps!
elasticsearch, apache solr, apache hbase, hadoop, redis, casssandra, amazon cloudwatch, mysql, memcached, apache kafka, apache zookeeper, apache storm, ubuntu, centOS, red hat, debian, puppet labs, java, senseiDB
 Search Hadoop and all its subprojects:

Switch to Plain View
Accumulo >> mail # dev >> One of Checkstyle's rules is 'no spaces at end of line', anyone upset if I update the code (1.6) to follow it?


+
David Medinets 2013-03-06, 15:23
+
Christopher 2013-03-06, 19:57
+
David Medinets 2013-03-06, 21:29
+
Billie Rinaldi 2013-03-06, 21:53
+
Christopher 2013-03-06, 22:57
Copy link to this message
-
Re: One of Checkstyle's rules is 'no spaces at end of line', anyone upset if I update the code (1.6) to follow it?
Done.

On Wed, Mar 6, 2013 at 5:57 PM, Christopher <[EMAIL PROTECTED]> wrote:
> +1 for this formatter change also.
>
> --
> Christopher L Tubbs II
> http://gravatar.com/ctubbsii
>
>
> On Wed, Mar 6, 2013 at 4:53 PM, Billie Rinaldi <[EMAIL PROTECTED]> wrote:
>> Do Java -> Code Style -> Formatter -> Edit (assuming you have the Accumulo
>> formatter) -> Indentation, and the last checkbox is "Empty lines".  Uncheck
>> that checkbox, Apply/OK, Apply, then export the formatter and replace
>> trunk/contrib/Eclipse-Accumulo-Codestyle.xml.
>>
>> Or it would probably also work to change the following line to false in the
>> Codestyle and re-import it.
>> <setting id="org.eclipse.jdt.core.formatter.indent_empty_lines"
>> value="true"/>
>>
>> Billie
>>
>>
>> On Wed, Mar 6, 2013 at 1:29 PM, David Medinets <[EMAIL PROTECTED]>wrote:
>>
>>> Chris, you seem to be correct. In fact, the Eclipse formatter actually
>>> adds whitespace on blank lines.
>>>
>>>   public static HdfsFileSystemConfigBuilder getInstance() {
>>>     return BUILDER;
>>>   }
>>> <space><space>
>>>   /**
>>>   */
>>>
>>> I removed the spaces show above. Then ran Source > Format. The spaces
>>> were inserted for me.
>>>
>>> I don't know how to make Eclipse stop adding the spaces. I tried
>>> turning on the 'Remove trailing whitespace on all lines' option in
>>> Java > Editor > Save Actions but that did not help.
>>>
>>> Any ideas?
>>>
>>> On Wed, Mar 6, 2013 at 2:57 PM, Christopher <[EMAIL PROTECTED]> wrote:
>>> > Wouldn't that rule conflict with our formatter? I'm pretty sure our
>>> > formatter allows "blank" lines to be indented with spaces.
>>> >
>>> > --
>>> > Christopher L Tubbs II
>>> > http://gravatar.com/ctubbsii
>>> >
>>> >
>>> > On Wed, Mar 6, 2013 at 10:23 AM, David Medinets
>>> > <[EMAIL PROTECTED]> wrote:
>>> >> I have a free day due to snowfall and while this is a fairly silly
>>> >> rule, writing a short script to rule all the java files through sed
>>> >> should be fairly painless. As part of this change, I will commit a
>>> >> one-rule checkstyle.xml file which just runs this 'no spaces at end of
>>> >> line' rule. Over time, more rules can be added to that align with the
>>> >> Accumulo community's style guidelines.
>>> >>
>>> >> Any objection?
>>>
+
Billie Rinaldi 2013-03-06, 20:18
+
David Medinets 2013-03-06, 20:20
+
Keith Turner 2013-03-07, 15:44
+
John Vines 2013-03-07, 15:49
+
Keith Turner 2013-03-07, 15:57
+
John Vines 2013-03-07, 16:01
+
Billie Rinaldi 2013-03-07, 16:20
+
Keith Turner 2013-03-07, 16:27
+
John Vines 2013-03-07, 16:24
+
Billie Rinaldi 2013-03-07, 16:28
+
David Medinets 2013-03-07, 16:55
+
Keith Turner 2013-03-07, 19:27
+
Keith Turner 2013-03-07, 17:13
+
Keith Turner 2013-03-07, 16:58
NEW: Monitor These Apps!
elasticsearch, apache solr, apache hbase, hadoop, redis, casssandra, amazon cloudwatch, mysql, memcached, apache kafka, apache zookeeper, apache storm, ubuntu, centOS, red hat, debian, puppet labs, java, senseiDB