Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Sqoop, mail # dev - Review Request 12713: SQOOP-1142 Sqoop2: Provide creater and last edited by to metadata structures


Copy link to this message
-
Re: Review Request 12713: SQOOP-1142 Sqoop2: Provide creater and last edited by to metadata structures
Jarek Cecho 2013-07-21, 16:38

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12713/#review23595
-----------------------------------------------------------
Hi Mengwei,
thank you very much for looking into this! I do have couple of comments:
common/src/main/java/org/apache/sqoop/json/ConnectionBean.java
<https://reviews.apache.org/r/12713/#comment47484>

    Nit: The other constants seems to be created with underscore, so I would suggest to remain consistent, e.g. CREATED_BY.

common/src/main/java/org/apache/sqoop/json/ConnectionBean.java
<https://reviews.apache.org/r/12713/#comment47485>

    Nit: The other constants seems to be create with underscore, so I would suggest to remain consistent, e.g. UPDATED_BY.

common/src/main/java/org/apache/sqoop/model/MAccountableEntity.java
<https://reviews.apache.org/r/12713/#comment47486>

    Nit: The phrase "last update by" seems weird. I would either suggest to say "last updated by" or "last update author/person/user/noun".

common/src/main/java/org/apache/sqoop/model/MAccountableEntity.java
<https://reviews.apache.org/r/12713/#comment47487>

    I think that default value should be NULL.

core/src/main/java/org/apache/sqoop/framework/JobManager.java
<https://reviews.apache.org/r/12713/#comment47488>

    I do have concern that adding new parameter each time we will need to add new information that will be propagated from client won't scale much. What about introducing something like ConnectionContext or HttpContext that will for start contain the username and in the future all additional details?

repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java
<https://reviews.apache.org/r/12713/#comment47489>

    This is backward incompatible change that needs to be handled properly with providing upgrade procedure. Please check out method createOrUpdateInternals() in DerbyRepositoryHandler class.

server/src/main/java/org/apache/sqoop/handler/ConnectionRequestHandler.java
<https://reviews.apache.org/r/12713/#comment47490>

    "Unknown" might be valid user name, let's use NULL to encode unknown user name.
Jarcec

- Jarek Cecho
On July 18, 2013, 5:09 p.m., Mengwei Ding wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12713/
> -----------------------------------------------------------
>
> (Updated July 18, 2013, 5:09 p.m.)
>
>
> Review request for Sqoop, Abraham Elmahrek, Hari Shreedharan, and Jarek Cecho.
>
>
> Bugs: SQOOP-1142
>     https://issues.apache.org/jira/browse/SQOOP-1142
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> commit d1cca7f5283847096dec27134edf56804f07e96d
> Author: Mengwei Ding <[EMAIL PROTECTED]>
> Date:   Wed Jul 17 10:48:05 2013 -0700
>
>     SQOOP-1142 Sqoop2: Provide creater and last edited by to metadata structures
>
> :100644 100644 b7b0436... a7a748b... M client/src/main/java/org/apache/sqoop/client/core/Constants.java
> :100644 100644 32bca71... 13b2475... M client/src/main/java/org/apache/sqoop/client/shell/ShowConnectionFunction.java
> :100644 100644 590e4e7... 70111e3... M client/src/main/java/org/apache/sqoop/client/shell/ShowJobFunction.java
> :100644 100644 cbc956d... a7343d4... M client/src/main/java/org/apache/sqoop/client/utils/SubmissionDisplayer.java
> :100644 100644 5537a8e... 5f077ea... M client/src/main/resources/client-resource.properties
> :100644 100644 b4e986a... c452662... M common/src/main/java/org/apache/sqoop/json/ConnectionBean.java
> :100644 100644 a830646... fddeb06... M common/src/main/java/org/apache/sqoop/json/JobBean.java
> :100644 100644 79490f8... 6efc8a0... M common/src/main/java/org/apache/sqoop/json/SubmissionBean.java
> :100644 100644 98768d6... ed604de... M common/src/main/java/org/apache/sqoop/json/util/FormSerialization.java
> :100644 100644 137e71c... 7db8d98... M common/src/main/java/org/apache/sqoop/model/MAccountableEntity.java