Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Bigtop, mail # dev - Review Request 12526: BIGTOP-939. Make usage of bigtop-tomcat more dynamic


Copy link to this message
-
Re: Review Request 12526: BIGTOP-939. Make usage of bigtop-tomcat more dynamic
Sean Mackrory 2013-07-15, 15:13

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12526/#review23156
-----------------------------------------------------------

bigtop-packages/src/common/hadoop/install_hadoop.sh
<https://reviews.apache.org/r/12526/#comment47007>

    Good catch - does look like it should be. Will fix...

bigtop-packages/src/common/oozie/install_oozie.sh
<https://reviews.apache.org/r/12526/#comment47008>

    We shouldn't be changing it in both places, if that's what you're asking. Having a specific "feature" in the init script to deal with ssl-server.xml is something Bruno expressed concern about on Jira too, so yes I am considering other approaches to this part.

bigtop-packages/src/common/oozie/install_oozie.sh
<https://reviews.apache.org/r/12526/#comment47010>

    We shouldn't be changing it in both places, if that's what you're asking. Bruno also expressed concern about the specific "feature" in the init to enable SSL, however, so I am considering different approaches to this aspect if it.
    
    We should not to have webapps/ under /etc/conf because it can contain binary artifacts, but this is one case where some configuration under webapps has had to change.

bigtop-packages/src/common/oozie/install_oozie.sh
<https://reviews.apache.org/r/12526/#comment47006>

    We could. I don't see much of a difference. Do you?

bigtop-packages/src/common/oozie/oozie.init
<https://reviews.apache.org/r/12526/#comment47003>

    What effect do you think forcefully removing it will have? It's already wrapped in a conditional to see if it exists. -f is more succinct, but am I missing something in your suggestion?

bigtop-packages/src/common/oozie/oozie.init
<https://reviews.apache.org/r/12526/#comment47005>

    What do you think forcefully removing it is going to do? It's more succinct than the existing conditional, but AFAIK there's no functional difference.

bigtop-packages/src/common/oozie/oozie.init
<https://reviews.apache.org/r/12526/#comment47004>

    They can still use their own custom configuration, but if they're upgrading from a previous version they'll need to copy in tomcat-deployment from conf.dist, so we ought to document that somewhere. (Is there a concept of "Release Notes" in Apache releases?)
    
    Not ideal, but all of the alternatives I can think of are much worse. We shouldn't be copying it into their custom config for them, we shouldn't leave it the way it is, etc...

bigtop-packages/src/common/sqoop/sqoop-server.sh
<https://reviews.apache.org/r/12526/#comment47009>

    Fixed. Should have no effect, though.
- Sean Mackrory
On July 12, 2013, 10:16 p.m., Sean Mackrory wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12526/
> -----------------------------------------------------------
>
> (Updated July 12, 2013, 10:16 p.m.)
>
>
> Review request for bigtop and Mark Grover.
>
>
> Bugs: BIGTOP-939
>     https://issues.apache.org/jira/browse/BIGTOP-939
>
>
> Repository: bigtop
>
>
> Description
> -------
>
> Explained on JIRA - uploaded here only for commenting convenience.
>
>
> Diffs
> -----
>
>   bigtop-packages/src/common/hadoop/hadoop-httpfs.svc de4d6d2
>   bigtop-packages/src/common/hadoop/httpfs.default e48e608
>   bigtop-packages/src/common/hadoop/install_hadoop.sh ed9cb5c
>   bigtop-packages/src/common/oozie/install_oozie.sh c27dd64
>   bigtop-packages/src/common/oozie/oozie-env.sh dd051f7
>   bigtop-packages/src/common/oozie/oozie.init 4600841
>   bigtop-packages/src/common/solr/install_solr.sh 4e09e40
>   bigtop-packages/src/common/solr/solr-server.init.debian 5b8b862
>   bigtop-packages/src/common/sqoop/install_sqoop.sh df4f489
>   bigtop-packages/src/common/sqoop/sqoop-server.sh b1de301
>   bigtop-packages/src/common/sqoop/sqoop.default cdec81c
>   bigtop-packages/src/common/sqoop/sqoop.sh afe1ac6