Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Drill >> mail # dev >> Review Request 15824: Patch for DRILL-281


Copy link to this message
-
Re: Review Request 15824: Patch for DRILL-281


> On Nov. 26, 2013, 8:31 p.m., Mehant Baid wrote:
> > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/broadcastsender/BroadcastSenderRootExec.java, line 84
> > <https://reviews.apache.org/r/15824/diff/1/?file=390554#file390554line84>
> >
> >     Why are you invoking retain() on your buffers? While getting the buffers from the value vector (BaseDataValueVector) calls retain() on the buffer before releasing it so the reference count should be set for the buffers. What am I missing?

I'm calling extra retain since I'm broadcasting to multiple endpoints, so the buffers is reused in my case instead of the usual getBuffers and send.
- Timothy
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15824/#review29458
-----------------------------------------------------------
On Nov. 24, 2013, 4:29 a.m., Timothy Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15824/
> -----------------------------------------------------------
>
> (Updated Nov. 24, 2013, 4:29 a.m.)
>
>
> Review request for drill.
>
>
> Bugs: DRILL-281
>     https://issues.apache.org/jira/browse/DRILL-281
>
>
> Repository: drill-git
>
>
> Description
> -------
>
>
> Diffs
> -----
>
>   exec/java-exec/src/main/java/org/apache/drill/exec/physical/base/AbstractPhysicalVisitor.java b8a7247648465f20a1dd7deb7faa786412c65ab1
>   exec/java-exec/src/main/java/org/apache/drill/exec/physical/base/PhysicalVisitor.java 040a4956e47e45a8ba5d906b55bd77f1e8e4e960
>   exec/java-exec/src/main/java/org/apache/drill/exec/physical/config/BroadcastSender.java PRE-CREATION
>   exec/java-exec/src/main/java/org/apache/drill/exec/physical/config/SingleBroadcastExchange.java PRE-CREATION
>   exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/ImplCreator.java efc0f5b8d84d6f659222f1448af14a3d8cc7e8d7
>   exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/ScreenCreator.java e1fb3ae00296dd53becfa832e3170fc7011ea3e4
>   exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/broadcastsender/BroadcastSenderCreator.java PRE-CREATION
>   exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/broadcastsender/BroadcastSenderRootExec.java PRE-CREATION
>   exec/java-exec/src/main/java/org/apache/drill/exec/record/WritableBatch.java e9b56db85538d4c8bc1aef1eed07e82874d1c28e
>   exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/TestSingleBroadcastExchange.java PRE-CREATION
>   exec/java-exec/src/test/resources/sender/broadcast_exchange.json PRE-CREATION
>
> Diff: https://reviews.apache.org/r/15824/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Timothy Chen
>
>