Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Plain View
Sqoop >> mail # dev >> Review Request: SQOOP-1046 Sqoop2: Importing single row using decimal splitter will not import anything


+
Jarek Cecho 2013-05-15, 04:17
Copy link to this message
-
Re: Review Request: SQOOP-1046 Sqoop2: Importing single row using decimal splitter will not import anything

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11171/#review20558
-----------------------------------------------------------

Ship it!
Ship It!

- Kathleen Ting
On May 15, 2013, 4:17 a.m., Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11171/
> -----------------------------------------------------------
>
> (Updated May 15, 2013, 4:17 a.m.)
>
>
> Review request for Sqoop.
>
>
> Description
> -------
>
> I've added condition that is checking for this edge case and is creating single split.
>
>
> This addresses bug SQOOP-1046.
>     https://issues.apache.org/jira/browse/SQOOP-1046
>
>
> Diffs
> -----
>
>   connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcImportPartitioner.java 6d1a9fd71c9dac587d8bc99d7ffc64e4a57672e7
>   connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestImportPartitioner.java 3150e7ce0490e16cba985361bd1365043aed04cc
>
> Diff: https://reviews.apache.org/r/11171/diff/
>
>
> Testing
> -------
>
> I've added new unit tests, testing this edge case. Both unit and integration tests seems to be passing.
>
>
> Thanks,
>
> Jarek Cecho
>
>