Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Plain View
Sqoop >> mail # dev >> Re: Review Request: SQOOP-690. Fix threading issues in SqoopOutputFormatLoadExecutor


+
Juhani Connolly 2012-11-16, 02:03
+
Jarek Jarcec Cecho 2012-11-16, 02:11
+
Hari Shreedharan 2012-11-15, 01:59
+
Hari Shreedharan 2012-11-16, 09:48
+
Jarek Cecho 2012-11-16, 17:22
+
Hari Shreedharan 2012-11-16, 18:15
Copy link to this message
-
Re: Review Request: SQOOP-690. Fix threading issues in SqoopOutputFormatLoadExecutor

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8063/
-----------------------------------------------------------

(Updated Nov. 16, 2012, 6:15 p.m.)
Review request for Sqoop.
Description
-------

Improved thread handling in SqoopOutputFormatLoadExecutor. Removed the synchronized blocks and wait/notify.
This addresses bug SQOOP-690.
    https://issues.apache.org/jira/browse/SQOOP-690
Diffs (updated)
-----

  connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcExportLoader.java ff7384c
  execution/mapreduce/src/main/java/org/apache/sqoop/job/etl/HdfsSequenceImportLoader.java 29a73b0
  execution/mapreduce/src/main/java/org/apache/sqoop/job/etl/HdfsTextImportLoader.java 711df0f
  execution/mapreduce/src/main/java/org/apache/sqoop/job/io/Data.java 41fceb8
  execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopOutputFormatLoadExecutor.java 0d636ae
  execution/mapreduce/src/test/java/org/apache/sqoop/job/TestMapReduce.java 6dcf784
  spi/src/main/java/org/apache/sqoop/job/etl/Loader.java 3a708df
  spi/src/main/java/org/apache/sqoop/job/io/DataReader.java 18e2fb7

Diff: https://reviews.apache.org/r/8063/diff/
Testing
-------

Ran unit tests, and on a real cluster.
Thanks,

Hari Shreedharan

+
Jarek Cecho 2012-11-16, 20:09