Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Plain View
Sqoop >> mail # dev >> Review Request 15192: SQOOP-1223 Enhance the password file capability to enable plugging-in custom loaders


+
Jarek Cecho 2013-11-02, 01:04
+
Hari Shreedharan 2013-11-05, 00:30
+
Jarek Cecho 2013-11-05, 18:03
Copy link to this message
-
Re: Review Request 15192: SQOOP-1223 Enhance the password file capability to enable plugging-in custom loaders

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15192/
-----------------------------------------------------------

(Updated Nov. 5, 2013, 6:47 p.m.)
Review request for Sqoop.
Changes
-------

Incorporated Hari's suggestion.
Bugs: SQOOP-1223
    https://issues.apache.org/jira/browse/SQOOP-1223
Repository: sqoop-trunk
Description
-------

I've changed the logic of loading passwords from password file to enable plugging in custom loader. I've also provided example implementation of advanced loader that is able to retrieve the password from encrypted file.
Diffs (updated)
-----

  src/java/org/apache/sqoop/SqoopOptions.java 13637b5ef8ddbaa3ac7bbbf920ff24d98b29127f
  src/java/org/apache/sqoop/tool/BaseSqoopTool.java 9230f82d8727de5e1d97b2846bead230f4d09abd
  src/java/org/apache/sqoop/util/CredentialsUtil.java 64124693a74ee01fcfcef9f637d60288262ba8f2
  src/java/org/apache/sqoop/util/password/CryptoFileLoader.java PRE-CREATION
  src/java/org/apache/sqoop/util/password/FilePasswordLoader.java PRE-CREATION
  src/java/org/apache/sqoop/util/password/PasswordLoader.java PRE-CREATION
  src/test/org/apache/sqoop/credentials/TestPassingSecurePassword.java 41a432a6138f7b92dec0d91180a1cd3de9a8b499

Diff: https://reviews.apache.org/r/15192/diff/
Testing
-------

Added unit tests that is testing all out-of-the-box available ECB methods in Java.
Thanks,

Jarek Cecho

+
Venkat Ranganathan 2013-11-05, 18:50
+
Jarek Cecho 2013-11-05, 19:18
+
Jarek Cecho 2013-11-05, 19:54
+
Venkat Ranganathan 2013-11-05, 19:38
+
Hari Shreedharan 2013-11-05, 19:09