Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Sqoop, mail # dev - Review Request: SQOOP-941 Do not send sensitive values from server to client


Copy link to this message
-
Re: Review Request: SQOOP-941 Do not send sensitive values from server to client
Jarek Cecho 2013-03-15, 20:33

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9911/#review17996
-----------------------------------------------------------
Hi Abe,
I've done my usual testing on real cluster and I've realized that there is small issue with the change. Would you mind taking a look?
common/src/main/java/org/apache/sqoop/json/util/FormSerialization.java
<https://reviews.apache.org/r/9911/#comment38013>

    Would you mind moving this condition to the if(!mInput.isEmpty()) condition on line 118?
    
    The reasoning for that is that we still need to transfer all metadata including sensitive field from server the client, we just do not want to send actual values (if they are present).
Jarcec

- Jarek Cecho
On March 13, 2013, 10:33 p.m., Abraham Elmahrek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9911/
> -----------------------------------------------------------
>
> (Updated March 13, 2013, 10:33 p.m.)
>
>
> Review request for Sqoop and Jarek Cecho.
>
>
> Description
> -------
>
> commit 4f2a75712f3aee722b052700b874a9d155d0c4ad
> Author: Abraham Elmahrek <[EMAIL PROTECTED]>
> Date:   Wed Mar 13 14:51:06 2013 -0700
>
>     SQOOP-941 Do not send sensitive values from server to client
>    
>     Added parameter to deserializer that filters out inputs with
>     'sensitive' argument.
>
> :100644 100644 57486b1... f65a9e1... M client/src/main/java/org/apache/sqoop/client/request/ConnectionRequest.java
> :100644 100644 499ebeb... 35e665b... M client/src/main/java/org/apache/sqoop/client/request/JobRequest.java
> :100644 100644 dbc0f93... b4e986a... M common/src/main/java/org/apache/sqoop/json/ConnectionBean.java
> :100644 100644 601040d... cbe049a... M common/src/main/java/org/apache/sqoop/json/ConnectorBean.java
> :100644 100644 4e07b6c... ad4753b... M common/src/main/java/org/apache/sqoop/json/FrameworkBean.java
> :100644 100644 a16c06e... a830646... M common/src/main/java/org/apache/sqoop/json/JobBean.java
> :100644 100644 074a579... 8189259... M common/src/main/java/org/apache/sqoop/json/JsonBean.java
> :100644 100644 9d8011b... 1ef72eb... M common/src/main/java/org/apache/sqoop/json/SubmissionBean.java
> :100644 100644 4bb0ffc... 86b637a... M common/src/main/java/org/apache/sqoop/json/ThrowableBean.java
> :100644 100644 747a228... fd36825... M common/src/main/java/org/apache/sqoop/json/ValidationBean.java
> :100644 100644 c37b2cc... 029a776... M common/src/main/java/org/apache/sqoop/json/VersionBean.java
> :100644 100644 8b40a54... ba28be3... M common/src/main/java/org/apache/sqoop/json/util/FormSerialization.java
> :100644 100644 1322dd3... cef646d... M common/src/test/java/org/apache/sqoop/json/TestConnectionBean.java
> :100644 100644 38cdb7e... e078474... M common/src/test/java/org/apache/sqoop/json/TestConnectorBean.java
> :100644 100644 5aa581b... 5cc110a... M common/src/test/java/org/apache/sqoop/json/TestFrameworkBean.java
> :100644 100644 3ea30ce... 6af1d8b... M common/src/test/java/org/apache/sqoop/json/TestJobBean.java
> :100644 100644 7c77db6... 6ee9aa1... M common/src/test/java/org/apache/sqoop/json/TestSubmissionBean.java
> :100644 100644 88267d1... 0cf0651... M common/src/test/java/org/apache/sqoop/json/TestThrowableBean.java
> :100644 100644 ebcb749... 95ea6e1... M common/src/test/java/org/apache/sqoop/json/TestValidationBean.java
> :100644 100644 dc0764e... 896c605... M server/src/main/java/org/apache/sqoop/server/SqoopProtocolServlet.java
>
>
> This addresses bug SQOOP-941.
>     https://issues.apache.org/jira/browse/SQOOP-941
>
>
> Diffs
> -----
>
>   client/src/main/java/org/apache/sqoop/client/request/ConnectionRequest.java 57486b146f45235ea5a75cabec861da4c38672c4
>   client/src/main/java/org/apache/sqoop/client/request/JobRequest.java 499ebebc64e0d306f199b6729e49fdffed604382
>   common/src/main/java/org/apache/sqoop/json/ConnectionBean.java dbc0f935bfbe7c164c79f51a49f5704f31a309a2