Sqoop, mail # dev - Review Request: SQOOP-907 Print out queries executed by Sqoop on mapreduce job side

Review Request: SQOOP-907 Print out queries executed by Sqoop on mapreduce job side

Jarek Cecho 2013-02-25, 01:40

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9580/
-----------------------------------------------------------

Review request for Sqoop.
Description
-------

We were already printing executed query on mapreduce side in debug mode, however as the mapreduce job do not inherit --verbose parameter, it was never printed. I've promote the message into info state. I've also added printing of current split.
This addresses bug SQOOP-907.
   https://issues.apache.org/jira/browse/SQOOP-907
Diffs
-----

  src/java/org/apache/sqoop/mapreduce/db/DBRecordReader.java 4c03c0d7061a5202bdfb4827e261743fd228689c
  src/java/org/apache/sqoop/mapreduce/db/DataDrivenDBInputFormat.java 140517a7659d18a803a5fd06f60cb07acb201074

Diff: https://reviews.apache.org/r/9580/diff/
Testing
-------

Unit tests seems to be passing and I've tried it out on real cluster.
Thanks,

Jarek Cecho

Re: Review Request: SQOOP-907 Print out queries executed by Sqoop on mapreduce job side

Cheolsoo Park 2013-03-02, 00:16

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9580/#review17283
-----------------------------------------------------------

Ship it!
Ship It!

- Cheolsoo Park
On Feb. 25, 2013, 1:40 a.m., Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9580/
> -----------------------------------------------------------
>
> (Updated Feb. 25, 2013, 1:40 a.m.)
>
>
> Review request for Sqoop.
>
>
> Description
> -------
>
> We were already printing executed query on mapreduce side in debug mode, however as the mapreduce job do not inherit --verbose parameter, it was never printed. I've promote the message into info state. I've also added printing of current split.
>
>
> This addresses bug SQOOP-907.
> https://issues.apache.org/jira/browse/SQOOP-907
>
>
> Diffs
> -----
>
> src/java/org/apache/sqoop/mapreduce/db/DBRecordReader.java 4c03c0d7061a5202bdfb4827e261743fd228689c
> src/java/org/apache/sqoop/mapreduce/db/DataDrivenDBInputFormat.java 140517a7659d18a803a5fd06f60cb07acb201074
>
> Diff: https://reviews.apache.org/r/9580/diff/
>
>
> Testing
> -------
>
> Unit tests seems to be passing and I've tried it out on real cluster.
>
>
> Thanks,
>
> Jarek Cecho
>
>