-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9846/
-----------------------------------------------------------

Review request for Sqoop and Jarek Cecho.
Description
-------

Expanded netezza tests
This addresses bug SQOOP-929.
    https://issues.apache.org/jira/browse/SQOOP-929
Diffs
-----

  src/test/com/cloudera/sqoop/manager/DirectNetezzaExportManualTest.java bbcd138
  src/test/com/cloudera/sqoop/manager/NetezzaExportManualTest.java PRE-CREATION
  src/test/com/cloudera/sqoop/manager/NetezzaImportManualTest.java 97399fe
  src/test/com/cloudera/sqoop/manager/NetezzaTestUtils.java 9f4c07c

Diff: https://reviews.apache.org/r/9846/diff/
Testing
-------

Ran against NZ VM and all tests pass.  Checkstyle validated with no new regressions introduced
Thanks,

Venkat Ranganathan

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9846/
-----------------------------------------------------------

(Updated March 12, 2013, 10:40 p.m.)
Review request for Sqoop and Jarek Cecho.
Changes
-------

Removed two test setup and tearDown methods that are basically inherited from parent
Description
-------

Expanded netezza tests
This addresses bug SQOOP-929.
    https://issues.apache.org/jira/browse/SQOOP-929
Diffs (updated)
-----

  src/test/com/cloudera/sqoop/manager/DirectNetezzaExportManualTest.java bbcd138
  src/test/com/cloudera/sqoop/manager/NetezzaExportManualTest.java PRE-CREATION
  src/test/com/cloudera/sqoop/manager/NetezzaImportManualTest.java 97399fe
  src/test/com/cloudera/sqoop/manager/NetezzaTestUtils.java 9f4c07c

Diff: https://reviews.apache.org/r/9846/diff/
Testing
-------

Ran against NZ VM and all tests pass.  Checkstyle validated with no new regressions introduced
Thanks,

Venkat Ranganathan

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9846/#review17946
-----------------------------------------------------------

Ship it!
Hi Venkat,
changes looks good to me and I've verified the tests in my environment as well. Would you mind uploading the patch to the jira? I'll commit it.

- Jarek Cecho
On March 12, 2013, 10:40 p.m., Venkat Ranganathan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9846/
> -----------------------------------------------------------
>
> (Updated March 12, 2013, 10:40 p.m.)
>
>
> Review request for Sqoop and Jarek Cecho.
>
>
> Description
> -------
>
> Expanded netezza tests
>
>
> This addresses bug SQOOP-929.
>     https://issues.apache.org/jira/browse/SQOOP-929
>
>
> Diffs
> -----
>
>   src/test/com/cloudera/sqoop/manager/DirectNetezzaExportManualTest.java bbcd138
>   src/test/com/cloudera/sqoop/manager/NetezzaExportManualTest.java PRE-CREATION
>   src/test/com/cloudera/sqoop/manager/NetezzaImportManualTest.java 97399fe
>   src/test/com/cloudera/sqoop/manager/NetezzaTestUtils.java 9f4c07c
>
> Diff: https://reviews.apache.org/r/9846/diff/
>
>
> Testing
> -------
>
> Ran against NZ VM and all tests pass.  Checkstyle validated with no new regressions introduced
>
>
> Thanks,
>
> Venkat Ranganathan
>
>

> On March 15, 2013, 4:03 a.m., Jarek Cecho wrote:
> > Hi Venkat,
> > changes looks good to me and I've verified the tests in my environment as well. Would you mind uploading the patch to the jira? I'll commit it.

Hi Jarek
 I uploaded the latest patch to the JIRA

THanks again

Venkat
- Venkat
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9846/#review17946
-----------------------------------------------------------
On March 12, 2013, 10:40 p.m., Venkat Ranganathan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9846/
> -----------------------------------------------------------
>
> (Updated March 12, 2013, 10:40 p.m.)
>
>
> Review request for Sqoop and Jarek Cecho.
>
>
> Description
> -------
>
> Expanded netezza tests
>
>
> This addresses bug SQOOP-929.
>     https://issues.apache.org/jira/browse/SQOOP-929
>
>
> Diffs
> -----
>
>   src/test/com/cloudera/sqoop/manager/DirectNetezzaExportManualTest.java bbcd138
>   src/test/com/cloudera/sqoop/manager/NetezzaExportManualTest.java PRE-CREATION
>   src/test/com/cloudera/sqoop/manager/NetezzaImportManualTest.java 97399fe
>   src/test/com/cloudera/sqoop/manager/NetezzaTestUtils.java 9f4c07c
>
> Diff: https://reviews.apache.org/r/9846/diff/
>
>
> Testing
> -------
>
> Ran against NZ VM and all tests pass.  Checkstyle validated with no new regressions introduced
>
>
> Thanks,
>
> Venkat Ranganathan
>
>