Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Pig, mail # dev - Review Request 15390: PIG-3561 Clean up PigStats and JobStats after PIG-3419


Copy link to this message
-
Re: Review Request 15390: PIG-3561 Clean up PigStats and JobStats after PIG-3419
Cheolsoo Park 2013-11-11, 18:55

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15390/
-----------------------------------------------------------

(Updated Nov. 11, 2013, 6:55 p.m.)
Review request for pig.
Changes
-------

I ran full unit tests and fixed TestPigRunner.testRegisterExternalJar.

With the updated patch, all unit tests pass now.
Bugs: PIG-3561
    https://issues.apache.org/jira/browse/PIG-3561
Repository: pig-git
Description
-------

The attached patch factors out methods/fields that can be used by MR and non-MR backends into PigStats and JobStats. PIG-3419 moved them to SimplePigStats and MRJobStats, but I found they are not MR-specific and applicable to non-MR backends such as Tez backend.
Diffs (updated)
-----

  src/org/apache/pig/tools/pigstats/JobStats.java 5eac24b
  src/org/apache/pig/tools/pigstats/PigStats.java 6d2e58e
  src/org/apache/pig/tools/pigstats/mapreduce/MRJobStats.java 1a37848
  src/org/apache/pig/tools/pigstats/mapreduce/MRPigStatsUtil.java 4bdcf19
  src/org/apache/pig/tools/pigstats/mapreduce/SimplePigStats.java bbfd5a9
  test/org/apache/pig/test/TestPigRunner.java c5d84cf

Diff: https://reviews.apache.org/r/15390/diff/
Testing
-------

ant test-commit
Thanks,

Cheolsoo Park