Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Flume, mail # dev - Review Request: FLUME-1731: SpoolableDirectorySource should have configurable support for deleting files it has already completed instead of renaming
Mike Percy
2013-01-15, 11:19
Mike Percy
2013-01-16, 00:51
Brock Noland
2013-01-16, 01:12
Copy link to this message
-
Re: Review Request: FLUME-1731: SpoolableDirectorySource should have configurable support for deleting files it has already completed instead of renaming
Brock Noland 2013-01-15, 23:20

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8957/#review15355
-----------------------------------------------------------

flume-ng-core/src/main/java/org/apache/flume/client/avro/ReliableSpoolingFileEventReader.java
<https://reviews.apache.org/r/8957/#comment33022>

    Missing space here
- Brock Noland
On Jan. 15, 2013, 11:19 a.m., Mike Percy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8957/
> -----------------------------------------------------------
>
> (Updated Jan. 15, 2013, 11:19 a.m.)
>
>
> Review request for Flume.
>
>
> Description
> -------
>
> Implement delete support for SpoolableDirectorySource. Also refactored the constructor logic to improve maintainability by putting in a Builder for the ReliableSpoolingFileEventReader.
>
>
> This addresses bug FLUME-1731.
>     https://issues.apache.org/jira/browse/FLUME-1731
>
>
> Diffs
> -----
>
>   flume-ng-core/src/main/java/org/apache/flume/client/avro/AvroCLIClient.java da23a75
>   flume-ng-core/src/main/java/org/apache/flume/client/avro/ReliableSpoolingFileEventReader.java f2d587f
>   flume-ng-core/src/main/java/org/apache/flume/source/SpoolDirectorySource.java 167193c
>   flume-ng-core/src/main/java/org/apache/flume/source/SpoolDirectorySourceConfigurationConstants.java 67549e0
>   flume-ng-core/src/test/java/org/apache/flume/client/avro/TestReliableSpoolingFileEventReader.java PRE-CREATION
>   flume-ng-core/src/test/java/org/apache/flume/client/avro/TestSpoolingFileLineReader.java bc10243
>   flume-ng-core/src/test/java/org/apache/flume/serialization/TestReliableSpoolingFileEventReader.java abc1827
>
> Diff: https://reviews.apache.org/r/8957/diff/
>
>
> Testing
> -------
>
> Added unit test. Existing unit tests pass.
>
>
> Thanks,
>
> Mike Percy
>
>