Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Plain View
Zookeeper, mail # dev - Review Request 16202: Log all exceptions not caught by ZK threads


+
Rakesh R 2013-12-12, 04:32
Copy link to this message
-
Re: Review Request 16202: Log all exceptions not caught by ZK threads
Rakesh R 2013-12-12, 08:49

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16202/
-----------------------------------------------------------

(Updated Dec. 12, 2013, 8:49 a.m.)
Review request for zookeeper, Benjamin Reed, fpj, Mahadev Konar, Patrick Hunt, and Raul Gutierrez Segales.
Changes
-------

Just updated JIRA id in header.
Bugs: ZOOKEEPER-602
    https://issues.apache.org/jira/browse/ZOOKEEPER-602
Repository: zookeeper
Description
-------

Improve exception handling - log all exceptions not caught by ZK threads. Will be helpful in debugging and gives the reason for thread exits.
Diffs
-----

  ./src/java/main/org/apache/zookeeper/ClientCnxn.java 1544413
  ./src/java/main/org/apache/zookeeper/server/NIOServerCnxnFactory.java 1544413
  ./src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java 1544413
  ./src/java/main/org/apache/zookeeper/server/SessionTrackerImpl.java 1544413
  ./src/java/main/org/apache/zookeeper/server/SyncRequestProcessor.java 1544413
  ./src/java/main/org/apache/zookeeper/server/WorkerService.java 1544413
  ./src/java/main/org/apache/zookeeper/server/ZooKeeperCriticalThread.java PRE-CREATION
  ./src/java/main/org/apache/zookeeper/server/ZooKeeperThread.java PRE-CREATION
  ./src/java/main/org/apache/zookeeper/server/quorum/AuthFastLeaderElection.java 1544413
  ./src/java/main/org/apache/zookeeper/server/quorum/CommitProcessor.java 1544413
  ./src/java/main/org/apache/zookeeper/server/quorum/FastLeaderElection.java 1544413
  ./src/java/main/org/apache/zookeeper/server/quorum/FollowerRequestProcessor.java 1544413
  ./src/java/main/org/apache/zookeeper/server/quorum/Leader.java 1544413
  ./src/java/main/org/apache/zookeeper/server/quorum/LearnerHandler.java 1544413
  ./src/java/main/org/apache/zookeeper/server/quorum/ObserverRequestProcessor.java 1544413
  ./src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java 1544413
  ./src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java 1544413
  ./src/java/main/org/apache/zookeeper/server/quorum/ReadOnlyRequestProcessor.java 1544413
  ./src/java/test/config/findbugsExcludeFile.xml 1544413
  ./src/java/test/org/apache/zookeeper/server/ZooKeeperThreadTest.java PRE-CREATION

Diff: https://reviews.apache.org/r/16202/diff/
Testing
-------

Includes basic test case
Thanks,

Rakesh R