-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9457/
-----------------------------------------------------------

Review request for Flume.
Description
-------

Added support for WAL disabling optionally.
This addresses bug FLUME-1906.
    https://issues.apache.org/jira/browse/FLUME-1906
Diffs
-----

  flume-ng-sinks/flume-ng-hbase-sink/src/main/java/org/apache/flume/sink/hbase/AsyncHBaseSink.java 0b6f885
  flume-ng-sinks/flume-ng-hbase-sink/src/main/java/org/apache/flume/sink/hbase/HBaseSink.java 835a69e
  flume-ng-sinks/flume-ng-hbase-sink/src/main/java/org/apache/flume/sink/hbase/HBaseSinkConfigurationConstants.java fb6bd4e

Diff: https://reviews.apache.org/r/9457/diff/
Testing
-------
Thanks,

Hari Shreedharan

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9457/
-----------------------------------------------------------

(Updated Feb. 14, 2013, 10:07 p.m.)
Review request for Flume.
Changes
-------

Updating based on Mubarak's feedback
Description
-------

Added support for WAL disabling optionally.
This addresses bug FLUME-1906.
    https://issues.apache.org/jira/browse/FLUME-1906
Diffs (updated)
-----

  flume-ng-sinks/flume-ng-hbase-sink/src/main/java/org/apache/flume/sink/hbase/AsyncHBaseSink.java 0b6f885
  flume-ng-sinks/flume-ng-hbase-sink/src/main/java/org/apache/flume/sink/hbase/HBaseSink.java 835a69e
  flume-ng-sinks/flume-ng-hbase-sink/src/main/java/org/apache/flume/sink/hbase/HBaseSinkConfigurationConstants.java fb6bd4e

Diff: https://reviews.apache.org/r/9457/diff/
Testing
-------
Thanks,

Hari Shreedharan

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9457/#review16619
-----------------------------------------------------------

Ship it!
Ship It!

- Mubarak Seyed
On Feb. 14, 2013, 10:07 p.m., Hari Shreedharan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9457/
> -----------------------------------------------------------
>
> (Updated Feb. 14, 2013, 10:07 p.m.)
>
>
> Review request for Flume.
>
>
> Description
> -------
>
> Added support for WAL disabling optionally.
>
>
> This addresses bug FLUME-1906.
>     https://issues.apache.org/jira/browse/FLUME-1906
>
>
> Diffs
> -----
>
>   flume-ng-sinks/flume-ng-hbase-sink/src/main/java/org/apache/flume/sink/hbase/AsyncHBaseSink.java 0b6f885
>   flume-ng-sinks/flume-ng-hbase-sink/src/main/java/org/apache/flume/sink/hbase/HBaseSink.java 835a69e
>   flume-ng-sinks/flume-ng-hbase-sink/src/main/java/org/apache/flume/sink/hbase/HBaseSinkConfigurationConstants.java fb6bd4e
>
> Diff: https://reviews.apache.org/r/9457/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Hari Shreedharan
>
>

> On Feb. 15, 2013, 12:16 a.m., Mubarak Seyed wrote:
> > Ship It!
>
> Hari Shreedharan wrote:
>     Mubarak,
>    
>     Could you please commit the patch too?

Sure, i will do it tonight. Thanks Hari.
- Mubarak
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9457/#review16619
-----------------------------------------------------------
On Feb. 14, 2013, 10:07 p.m., Hari Shreedharan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9457/
> -----------------------------------------------------------
>
> (Updated Feb. 14, 2013, 10:07 p.m.)
>
>
> Review request for Flume.
>
>
> Description
> -------
>
> Added support for WAL disabling optionally.
>
>
> This addresses bug FLUME-1906.
>     https://issues.apache.org/jira/browse/FLUME-1906
>
>
> Diffs
> -----
>
>   flume-ng-sinks/flume-ng-hbase-sink/src/main/java/org/apache/flume/sink/hbase/AsyncHBaseSink.java 0b6f885
>   flume-ng-sinks/flume-ng-hbase-sink/src/main/java/org/apache/flume/sink/hbase/HBaseSink.java 835a69e
>   flume-ng-sinks/flume-ng-hbase-sink/src/main/java/org/apache/flume/sink/hbase/HBaseSinkConfigurationConstants.java fb6bd4e
>
> Diff: https://reviews.apache.org/r/9457/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Hari Shreedharan
>
>

Thanks!

--
Hari Shreedharan
On Thursday, February 14, 2013 at 4:52 PM, Mubarak Seyed wrote:

>
>
> > On Feb. 15, 2013, 12:16 a.m., Mubarak Seyed wrote:
> > > Ship It!
> >
> >
> > Hari Shreedharan wrote:
> > Mubarak,
> >
> > Could you please commit the patch too?
> >
>
>
> Sure, i will do it tonight. Thanks Hari.
>
>
> - Mubarak
>
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9457/#review16619
> -----------------------------------------------------------
>
>
> On Feb. 14, 2013, 10:07 p.m., Hari Shreedharan wrote:
> >
> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > https://reviews.apache.org/r/9457/
> > -----------------------------------------------------------
> >
> > (Updated Feb. 14, 2013, 10:07 p.m.)
> >
> >
> > Review request for Flume.
> >
> >
> > Description
> > -------
> >
> > Added support for WAL disabling optionally.
> >
> >
> > This addresses bug FLUME-1906.
> > https://issues.apache.org/jira/browse/FLUME-1906
> >
> >
> > Diffs
> > -----
> >
> > flume-ng-sinks/flume-ng-hbase-sink/src/main/java/org/apache/flume/sink/hbase/AsyncHBaseSink.java 0b6f885
> > flume-ng-sinks/flume-ng-hbase-sink/src/main/java/org/apache/flume/sink/hbase/HBaseSink.java 835a69e
> > flume-ng-sinks/flume-ng-hbase-sink/src/main/java/org/apache/flume/sink/hbase/HBaseSinkConfigurationConstants.java fb6bd4e
> >
> > Diff: https://reviews.apache.org/r/9457/diff/
> >
> >
> > Testing
> > -------
> >
> >
> > Thanks,
> >
> > Hari Shreedharan

> On Feb. 15, 2013, 12:16 a.m., Mubarak Seyed wrote:
> > Ship It!

Mubarak,

Could you please commit the patch too?
- Hari
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9457/#review16619
-----------------------------------------------------------
On Feb. 14, 2013, 10:07 p.m., Hari Shreedharan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9457/
> -----------------------------------------------------------
>
> (Updated Feb. 14, 2013, 10:07 p.m.)
>
>
> Review request for Flume.
>
>
> Description
> -------
>
> Added support for WAL disabling optionally.
>
>
> This addresses bug FLUME-1906.
>     https://issues.apache.org/jira/browse/FLUME-1906
>
>
> Diffs
> -----
>
>   flume-ng-sinks/flume-ng-hbase-sink/src/main/java/org/apache/flume/sink/hbase/AsyncHBaseSink.java 0b6f885
>   flume-ng-sinks/flume-ng-hbase-sink/src/main/java/org/apache/flume/sink/hbase/HBaseSink.java 835a69e
>   flume-ng-sinks/flume-ng-hbase-sink/src/main/java/org/apache/flume/sink/hbase/HBaseSinkConfigurationConstants.java fb6bd4e
>
> Diff: https://reviews.apache.org/r/9457/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Hari Shreedharan
>
>

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9457/#review16613
-----------------------------------------------------------
Looks good to me. Thanks.
flume-ng-sinks/flume-ng-hbase-sink/src/main/java/org/apache/flume/sink/hbase/AsyncHBaseSink.java
<https://reviews.apache.org/r/9457/#comment35247>

    when config changes from enableWal = false to enableWal = true, don't we need to log it? I think it helps on debugging.

flume-ng-sinks/flume-ng-hbase-sink/src/main/java/org/apache/flume/sink/hbase/HBaseSink.java
<https://reviews.apache.org/r/9457/#comment35250>

    i think "memstore of the region in a region server"
- Mubarak Seyed
On Feb. 14, 2013, 9:33 p.m., Hari Shreedharan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9457/
> -----------------------------------------------------------
>
> (Updated Feb. 14, 2013, 9:33 p.m.)
>
>
> Review request for Flume.
>
>
> Description
> -------
>
> Added support for WAL disabling optionally.
>
>
> This addresses bug FLUME-1906.
>     https://issues.apache.org/jira/browse/FLUME-1906
>
>
> Diffs
> -----
>
>   flume-ng-sinks/flume-ng-hbase-sink/src/main/java/org/apache/flume/sink/hbase/AsyncHBaseSink.java 0b6f885
>   flume-ng-sinks/flume-ng-hbase-sink/src/main/java/org/apache/flume/sink/hbase/HBaseSink.java 835a69e
>   flume-ng-sinks/flume-ng-hbase-sink/src/main/java/org/apache/flume/sink/hbase/HBaseSinkConfigurationConstants.java fb6bd4e
>
> Diff: https://reviews.apache.org/r/9457/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Hari Shreedharan
>
>