Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Plain View
Flume >> mail # dev >> Review Request: FLUME-1870. Flume sends non-numeric values with type as float to Ganglia causing ganglia to crash


+
Hari Shreedharan 2013-01-23, 22:12
Copy link to this message
-
Re: Review Request: FLUME-1870. Flume sends non-numeric values with type as float to Ganglia causing ganglia to crash

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9075/
-----------------------------------------------------------

(Updated Jan. 23, 2013, 10:45 p.m.)
Review request for Flume.
Changes
-------

Updated diff to handle this in case of Ganglia 3 too.
Description
-------

Added code to convert the value to float, if it fails, the type is set as string.
This addresses bug FLUME-1870.
    https://issues.apache.org/jira/browse/FLUME-1870
Diffs (updated)
-----

  flume-ng-core/src/main/java/org/apache/flume/instrumentation/GangliaServer.java 8d34fee

Diff: https://reviews.apache.org/r/9075/diff/
Testing
-------

All unit tests pass.
Thanks,

Hari Shreedharan

+
Juhani Connolly 2013-01-24, 10:23
+
Alexander Alten-Lorenz 2013-01-24, 10:33
+
Mike Percy 2013-01-24, 19:21