Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Flume >> mail # dev >> Review Request 16151: Patch for FLUME-2006 - in Avro the batch size is called batch-size, in all other sources batchSize


Copy link to this message
-
Review Request 16151: Patch for FLUME-2006 - in Avro the batch size is called batch-size, in all other sources batchSize

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16151/
-----------------------------------------------------------

Review request for Flume.
Bugs: FLUME-2006
    https://issues.apache.org/jira/browse/FLUME-2006
Repository: flume-git
Description
-------

Patch based on discussion on JIRA
1. If batch-size is present, a warning is logged to to use batchSize
2. If both, batch-size and batchSize are present, an Exception is thrown, recommending to use batchSize
3. batch-size property has been marked as deprecated
Diffs
-----

  flume-ng-core/src/main/java/org/apache/flume/sink/AbstractRpcSink.java 5146834
  flume-ng-core/src/test/java/org/apache/flume/sink/TestAvroSink.java 757a536
  flume-ng-sdk/pom.xml d5d50cf
  flume-ng-sdk/src/main/java/org/apache/flume/api/FailoverRpcClient.java db6905a
  flume-ng-sdk/src/main/java/org/apache/flume/api/NettyAvroRpcClient.java a2eb264
  flume-ng-sdk/src/main/java/org/apache/flume/api/RpcClientConfigurationConstants.java 136c504
  flume-ng-sdk/src/main/java/org/apache/flume/api/RpcClientFactory.java 00d9cf0
  flume-ng-sdk/src/main/java/org/apache/flume/api/ThriftRpcClient.java cf45ab9

Diff: https://reviews.apache.org/r/16151/diff/
Testing
-------

Existing test cases which use batch-size pass
Added test case to check behaviour if both properties are present
Thanks,

Ashish Paliwal