Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Accumulo, mail # dev - Review Request 14995: ACCUMULO-1679 - Purges TFile by rolling the two static calls into BCFile


Copy link to this message
-
Re: Review Request 14995: ACCUMULO-1679 - Purges TFile by rolling the two static calls into BCFile
John Vines 2013-10-28, 22:09

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14995/
-----------------------------------------------------------

(Updated Oct. 28, 2013, 10:09 p.m.)
Review request for accumulo.
Changes
-------

Updated with patch which removed Chunk as well
Bugs: ACCUMULO-1679
    https://issues.apache.org/jira/browse/ACCUMULO-1679
Repository: accumulo
Description
-------

Dirt simple fix which moves the 2 static variables and methods into BCFile. I'm pretty sure we can't go about renaming those constants, but I could be mistaken. General trivialness of this fix is why I'm review boarding it - it seems too easy.
Diffs (updated)
-----

  core/src/main/java/org/apache/accumulo/core/file/rfile/bcfile/BCFile.java 2d9f6af
  core/src/main/java/org/apache/accumulo/core/file/rfile/bcfile/Chunk.java a075d87
  core/src/main/java/org/apache/accumulo/core/file/rfile/bcfile/Compression.java e89bb40
  core/src/main/java/org/apache/accumulo/core/file/rfile/bcfile/TFile.java f2cb326
  core/src/main/java/org/apache/accumulo/core/file/rfile/bcfile/TFileDumper.java d5b0a1b

Diff: https://reviews.apache.org/r/14995/diff/
Testing
-------
Thanks,

John Vines