Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Drill, mail # dev - Review Request 14764: Patch for DRILL-230


Copy link to this message
-
Re: Review Request 14764: Patch for DRILL-230
Jacques Nadeau 2013-10-30, 21:07

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14764/#review27560
-----------------------------------------------------------

Ship it!

exec/java-exec/src/main/java/org/apache/drill/exec/client/QuerySubmitter.java
<https://reviews.apache.org/r/14764/#comment53498>

    Can you add a TODO: block here noting that we need to update this to be push instead of pull.

exec/java-exec/src/main/java/org/apache/drill/exec/physical/config/OrderedPartitionExchange.java
<https://reviews.apache.org/r/14764/#comment53712>

    should there be additional preconditions checks on each of these arguments?

exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/orderedpartitioner/OrderedPartitionRecordBatch.java
<https://reviews.apache.org/r/14764/#comment53713>

    can you make these lower case
- Jacques Nadeau
On Oct. 25, 2013, 12:17 p.m., Steven Phillips wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14764/
> -----------------------------------------------------------
>
> (Updated Oct. 25, 2013, 12:17 p.m.)
>
>
> Review request for drill.
>
>
> Bugs: DRILL-230
>     https://issues.apache.org/jira/browse/DRILL-230
>
>
> Repository: drill-git
>
>
> Description
> -------
>
> DRILL-230: address additional code review comments
>
>
> added some comments
>
>
> rename some classes
>
>
> Addressing comments in code review, abstract out references to HazelCache
>
>
> DRILL-230: Build a sampling range partitioner
>
>
> Diffs
> -----
>
>   common/src/main/java/org/apache/drill/common/expression/OutputTypeDeterminer.java ed227ec4a958077922bbcf943f5dcadc1b05686e
>   common/src/main/java/org/apache/drill/common/util/DataInputInputStream.java PRE-CREATION
>   common/src/main/java/org/apache/drill/common/util/DataOutputOutputStream.java PRE-CREATION
>   distribution/src/resources/submit_plan fee182052b8636e3bbf5e9545816057f89bba32a
>   exec/java-exec/pom.xml f6543f9b63bd3385fb0dfefa2b2367c1eab97484
>   exec/java-exec/src/main/java/org/apache/drill/exec/cache/Counter.java PRE-CREATION
>   exec/java-exec/src/main/java/org/apache/drill/exec/cache/DistributedCache.java d1b0e89adc373b0d515860f5985d88e5203d8a65
>   exec/java-exec/src/main/java/org/apache/drill/exec/cache/DistributedMap.java PRE-CREATION
>   exec/java-exec/src/main/java/org/apache/drill/exec/cache/DistributedMultiMap.java PRE-CREATION
>   exec/java-exec/src/main/java/org/apache/drill/exec/cache/DrillSerializable.java PRE-CREATION
>   exec/java-exec/src/main/java/org/apache/drill/exec/cache/HCDrillSerializableWrapper.java PRE-CREATION
>   exec/java-exec/src/main/java/org/apache/drill/exec/cache/HCSerializableWrapperClasses.java PRE-CREATION
>   exec/java-exec/src/main/java/org/apache/drill/exec/cache/HazelCache.java 22435bd0396726860b6b30657787098f4a4d94c7
>   exec/java-exec/src/main/java/org/apache/drill/exec/cache/LocalCache.java 79675c3a6c2c573941d965a62da73d9447ee90e5
>   exec/java-exec/src/main/java/org/apache/drill/exec/cache/VectorContainerSerializable.java PRE-CREATION
>   exec/java-exec/src/main/java/org/apache/drill/exec/client/DrillClient.java 3dadb0cc87c7d234cc545acec505aab46fe689e1
>   exec/java-exec/src/main/java/org/apache/drill/exec/client/QuerySubmitter.java 2d5c10594ff4212515c7a84e6909db5cc1402717
>   exec/java-exec/src/main/java/org/apache/drill/exec/expr/ExpressionTreeMaterializer.java bb9fc251f38f95c0e7174c934408cd99456a2286
>   exec/java-exec/src/main/java/org/apache/drill/exec/physical/base/AbstractPhysicalVisitor.java 286144bdefdff60d665186bc4730b3123981f006
>   exec/java-exec/src/main/java/org/apache/drill/exec/physical/base/PhysicalVisitor.java a36b65a012f9b86c584609f18f45cae259046906
>   exec/java-exec/src/main/java/org/apache/drill/exec/physical/config/OrderedPartitionExchange.java PRE-CREATION