Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Plain View
Flume >> mail # dev >> Review Request: FLUME-1772: AbstractConfigurationProvider should remove component which throws exception from configure method.


+
Brock Noland 2012-12-07, 20:37
+
Hari Shreedharan 2012-12-08, 00:39
+
Hari Shreedharan 2012-12-08, 01:12
+
Brock Noland 2012-12-08, 03:37
+
Hari Shreedharan 2012-12-09, 07:33
+
Brock Noland 2012-12-09, 17:41
+
Brock Noland 2012-12-12, 19:30
Copy link to this message
-
Re: Review Request: FLUME-1772: AbstractConfigurationProvider should remove component which throws exception from configure method.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8421/#review14378
-----------------------------------------------------------

flume-ng-node/src/main/java/org/apache/flume/node/AbstractConfigurationProvider.java
<https://reviews.apache.org/r/8421/#comment31139>

    If channels list is empty should we throw? I think we should just remove the source and log it right?

flume-ng-node/src/main/java/org/apache/flume/node/AbstractConfigurationProvider.java
<https://reviews.apache.org/r/8421/#comment31140>

    Same as above, should we throw or remove the component?

flume-ng-node/src/main/java/org/apache/flume/node/AbstractConfigurationProvider.java
<https://reviews.apache.org/r/8421/#comment31141>

    same as above

flume-ng-node/src/test/java/org/apache/flume/node/TestAbstractConfigurationProvider.java
<https://reviews.apache.org/r/8421/#comment30597>

    should be called testSourceAndSinkThrowExceptionDuringConfiguration()
- Hari Shreedharan
On Dec. 12, 2012, 7:30 p.m., Brock Noland wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8421/
> -----------------------------------------------------------
>
> (Updated Dec. 12, 2012, 7:30 p.m.)
>
>
> Review request for Flume.
>
>
> Description
> -------
>
> Catches Exception around all the configure() methods of components. If they throw an exception, they are removed from the configuration (not added).
>
>
> This addresses bug FLUME-1772.
>     https://issues.apache.org/jira/browse/FLUME-1772
>
>
> Diffs
> -----
>
>   flume-ng-node/src/main/java/org/apache/flume/node/AbstractConfigurationProvider.java daef76b
>   flume-ng-node/src/test/java/org/apache/flume/node/TestAbstractConfigurationProvider.java 25001b1
>
> Diff: https://reviews.apache.org/r/8421/diff/
>
>
> Testing
> -------
>
> Tests added for source, channel, and sink.
>
>
> Thanks,
>
> Brock Noland
>
>

+
Brock Noland 2012-12-18, 20:51
+
Hari Shreedharan 2012-12-18, 20:58
+
Brock Noland 2012-12-18, 21:05
+
Brock Noland 2012-12-18, 21:12
+
Hari Shreedharan 2012-12-18, 21:17
+
Brock Noland 2012-12-18, 21:11
+
Hari Shreedharan 2012-12-19, 00:56
+
Brock Noland 2012-12-19, 01:15
+
Brock Noland 2012-12-19, 01:15
+
Brock Noland 2012-12-19, 16:26
+
Hari Shreedharan 2012-12-20, 02:19
+
Brock Noland 2012-12-20, 04:28
+
Hari Shreedharan 2012-12-20, 04:35