Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Hive >> mail # dev >> Re: Review Request 11334: HIVE-4568 Beeline needs to support resolving variables


Copy link to this message
-
Re: Review Request 11334: HIVE-4568 Beeline needs to support resolving variables

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11334/#review25500
-----------------------------------------------------------

beeline/src/java/org/apache/hive/beeline/BeeLine.java
<https://reviews.apache.org/r/11334/#comment49947>

    Okay. Will do

beeline/src/java/org/apache/hive/beeline/BeeLineOpts.java
<https://reviews.apache.org/r/11334/#comment49948>

    HiveConf and HiveVar are two different sets of properties. The prefixes are:
    
    HIVECONF_PREFIX = "hiveconf:";
    HIVEVAR_PREFIX = "hivevar:";
    
    Naming to hiveConfVars might cause confusion, as here we are dealing only hive variables.

beeline/src/java/org/apache/hive/beeline/BeeLineOpts.java
<https://reviews.apache.org/r/11334/#comment49949>

    Same comments as above.

beeline/src/java/org/apache/hive/beeline/DatabaseConnection.java
<https://reviews.apache.org/r/11334/#comment49950>

    Okay. Will do.
- Xuefu Zhang
On Aug. 21, 2013, 5:42 a.m., Xuefu Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11334/
> -----------------------------------------------------------
>
> (Updated Aug. 21, 2013, 5:42 a.m.)
>
>
> Review request for hive and Ashutosh Chauhan.
>
>
> Bugs: HIVE-4568
>     https://issues.apache.org/jira/browse/HIVE-4568
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> 1. Added command variable substition
> 2. Added test case
>
>
> Diffs
> -----
>
>   beeline/src/java/org/apache/hive/beeline/BeeLine.java 4c6eb9b
>   beeline/src/java/org/apache/hive/beeline/BeeLine.properties b6650cf
>   beeline/src/java/org/apache/hive/beeline/BeeLineOpts.java 61bdeee
>   beeline/src/java/org/apache/hive/beeline/DatabaseConnection.java c70003d
>   beeline/src/test/org/apache/hive/beeline/src/test/TestBeeLineWithArgs.java 030f6b0
>
> Diff: https://reviews.apache.org/r/11334/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Xuefu Zhang
>
>