Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Drill >> mail # dev >> Review Request 14764: Patch for DRILL-230


Copy link to this message
-
Re: Review Request 14764: Patch for DRILL-230

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14764/#review27233
-----------------------------------------------------------

exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/orderedpartitioner/OrderedPartitionRecordBatch.java
<https://reviews.apache.org/r/14764/#comment53041>

    I wonder if not breaking into methods, at least add some comments (places like tagged) of what's the intention of some code? It's a fairly long method and takes a while to understand what's going on

exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/orderedpartitioner/TestOrderedPartitionExchange.java
<https://reviews.apache.org/r/14764/#comment53042>

    I was hoping looking at the test I could understand overall how OrderedPartitioner can be used, but I'm not sure I totally get it. Why is your test testing for means and averages with a OrderedPartitioner?
    Overall I think that for the operators/exchanges we're adding it will probably be best to provide some description of what the intention of the operator is, as we clearly have no description in  any of them and it will become a hard barrier for contributers (such as me) to what's going on
- Timothy Chen
On Oct. 18, 2013, 9:21 p.m., Steven Phillips wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14764/
> -----------------------------------------------------------
>
> (Updated Oct. 18, 2013, 9:21 p.m.)
>
>
> Review request for drill.
>
>
> Bugs: DRILL-230
>     https://issues.apache.org/jira/browse/DRILL-230
>
>
> Repository: drill-git
>
>
> Description
> -------
>
> DRILL-230: Build a sampling range partitioner
>
>
> Diffs
> -----
>
>   common/src/main/java/org/apache/drill/common/expression/OutputTypeDeterminer.java ed227ec4a958077922bbcf943f5dcadc1b05686e
>   distribution/src/resources/submit_plan fee182052b8636e3bbf5e9545816057f89bba32a
>   exec/java-exec/pom.xml f6543f9b63bd3385fb0dfefa2b2367c1eab97484
>   exec/java-exec/src/main/java/org/apache/drill/exec/cache/HazelCache.java 22435bd0396726860b6b30657787098f4a4d94c7
>   exec/java-exec/src/main/java/org/apache/drill/exec/cache/VectorWrap.java PRE-CREATION
>   exec/java-exec/src/main/java/org/apache/drill/exec/client/DrillClient.java 3dadb0cc87c7d234cc545acec505aab46fe689e1
>   exec/java-exec/src/main/java/org/apache/drill/exec/client/QuerySubmitter.java 2d5c10594ff4212515c7a84e6909db5cc1402717
>   exec/java-exec/src/main/java/org/apache/drill/exec/expr/ExpressionTreeMaterializer.java bb9fc251f38f95c0e7174c934408cd99456a2286
>   exec/java-exec/src/main/java/org/apache/drill/exec/physical/base/AbstractPhysicalVisitor.java 286144bdefdff60d665186bc4730b3123981f006
>   exec/java-exec/src/main/java/org/apache/drill/exec/physical/base/PhysicalVisitor.java a36b65a012f9b86c584609f18f45cae259046906
>   exec/java-exec/src/main/java/org/apache/drill/exec/physical/config/OrderedPartitionExchange.java PRE-CREATION
>   exec/java-exec/src/main/java/org/apache/drill/exec/physical/config/OrderedPartitionSender.java PRE-CREATION
>   exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/ImplCreator.java 94acc0e1a7f96e61cab1f0218204aa3957cbbf89
>   exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/ScanBatch.java 10d595a509cbeac4f45a7d57276834f207c21ea0
>   exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/WireRecordBatch.java 5f8b4167db98f934a05c27822cec50bb7af71036
>   exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/orderedpartitioner/OrderedPartitionBatchCreator.java PRE-CREATION
>   exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/orderedpartitioner/OrderedPartitionProjector.java PRE-CREATION
>   exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/orderedpartitioner/OrderedPartitionProjectorTemplate.java PRE-CREATION