Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Plain View
Pig >> mail # dev >> Review Request: Refactor physical operators to remove methods parameters that are always null


Copy link to this message
-
Review Request: Refactor physical operators to remove methods parameters that are always null

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11203/
-----------------------------------------------------------

Review request for pig, Daniel Dai, Dmitriy Ryaboy, Cheolsoo Park, and Bill Graham.
Description
-------

Refactor physical operators to remove methods parameters that are always null
This addresses bug PIG-3307.
    https://issues.apache.org/jira/browse/PIG-3307
Diffs
-----

  src/org/apache/pig/backend/hadoop/executionengine/mapReduceLayer/MergeJoinIndexer.java d5aff3d
  src/org/apache/pig/backend/hadoop/executionengine/mapReduceLayer/PigCombiner.java 6cfc8c0
  src/org/apache/pig/backend/hadoop/executionengine/mapReduceLayer/PigGenericMapBase.java 7c499f6
  src/org/apache/pig/backend/hadoop/executionengine/mapReduceLayer/PigGenericMapReduce.java 6145214
  src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/PhysicalOperator.java fc0112a
  src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/expressionOperators/Add.java 5bceca6
  src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/expressionOperators/BinaryComparisonOperator.java 3e434f3
  src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/expressionOperators/ComparisonOperator.java 51d9f34
  src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/expressionOperators/ConstantExpression.java 7e4cffa
  src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/expressionOperators/Divide.java bdcc72b
  src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/expressionOperators/EqualToExpr.java a767c36
  src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/expressionOperators/ExpressionOperator.java 9cca2c3
  src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/expressionOperators/GTOrEqualToExpr.java b5e3c83
  src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/expressionOperators/GreaterThanExpr.java f3b5d44
  src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/expressionOperators/LTOrEqualToExpr.java 35786c0
  src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/expressionOperators/LessThanExpr.java c9b3157
  src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/expressionOperators/Mod.java 1108846
  src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/expressionOperators/Multiply.java 2795b78
  src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/expressionOperators/NotEqualToExpr.java 294f84a
  src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/expressionOperators/POAnd.java f24c2ac
  src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/expressionOperators/POBinCond.java 312f3ac
  src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/expressionOperators/POCast.java 987cc21
  src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/expressionOperators/POIsNull.java 9ea89f7
  src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/expressionOperators/POMapLookUp.java fd5573f
  src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/expressionOperators/PONegative.java 8d3fcb1
  src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/expressionOperators/PONot.java 973dfc5
  src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/expressionOperators/POOr.java 498eb12
  src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/expressionOperators/POProject.java 8886df7
  src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/expressionOperators/PORegexp.java 6634915
  src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/expressionOperators/PORelationToExprProject.java e400a95
  src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/expressionOperators/POUserComparisonFunc.java 1aa1671
  src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/expressionOperators/POUserFunc.java 167cf06
  src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/expressionOperators/Subtract.java 4999995
  src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/relationalOperators/POCollectedGroup.java a5adaf7
  src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/relationalOperators/POCombinerPackage.java 4a58a7e
  src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/relationalOperators/POCounter.java 30dcea2
  src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/relationalOperators/POCross.java b90b0a2
  src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/relationalOperators/PODemux.java e26c611
  src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/relationalOperators/PODistinct.java ed2d39e
  src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/relationalOperators/POFRJoin.java a4abdd8
  src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/relationalOperators/POFilter.java 552d6fa
  src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/relationalOperators/POForEach.java 45de398
  src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/relationalOperators/POGlobalRearrange.java 5fac709
  src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/relationalOperators/POJoinPackage.java 7e357ec
  src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/relationalOperators/POLimit.java 3a2542b
  src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/relationalOperators/POLoad.java 55bd896
  src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/relationalOperators/POLocalRearrange.java 88621ba
  src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/relationalOperators/POMergeCogroup.java eea840a
  src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/relationalOperators/POMergeJoin.java b6a4d96
  src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/relationalO
+
Cheolsoo Park 2013-05-17, 15:12
+
Julien Le Dem 2013-05-17, 23:06