Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Pig >> mail # dev >> Re: [jira] Commented: (PIG-1420) Make CONCAT act on all fields of a tuple, instead of just the first two fields of a tuple


Copy link to this message
-
RE: [jira] Commented: (PIG-1420) Make CONCAT act on all fields of a tuple, instead of just the first two fields of a tuple
I think we agreed not to do it for this release. SO I think you are off the hook for now :)

Olga

-----Original Message-----
From: Russell Jurney [mailto:[EMAIL PROTECTED]]
Sent: Tuesday, August 17, 2010 3:28 PM
To: [EMAIL PROTECTED]
Subject: Re: [jira] Commented: (PIG-1420) Make CONCAT act on all fields of a tuple, instead of just the first two fields of a tuple

I can hack on this this weekend.  Sorry for the absence on the JIRAs, been
slammed on work stuff.

Russ

On Tue, Aug 17, 2010 at 2:46 PM, Olga Natkovich (JIRA) <[EMAIL PROTECTED]>wrote:

>
>    [
> https://issues.apache.org/jira/browse/PIG-1420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12899608#action_12899608]
>
> Olga Natkovich commented on PIG-1420:
> -------------------------------------
>
> 2 and 3 are backward incompatible with 0.7 and we really don't want to
> break compatibility in this release. So I would propose option 1 and proper
> fix in 0.9
>
> > Make CONCAT act on all fields of a tuple, instead of just the first two
> fields of a tuple
> >
> -----------------------------------------------------------------------------------------
> >
> >                 Key: PIG-1420
> >                 URL: https://issues.apache.org/jira/browse/PIG-1420
> >             Project: Pig
> >          Issue Type: Improvement
> >          Components: impl
> >    Affects Versions: 0.8.0
> >            Reporter: Russell Jurney
> >            Assignee: Russell Jurney
> >             Fix For: 0.8.0
> >
> >         Attachments: addconcat2.patch, PIG-1420.2.patch
> >
> >   Original Estimate: 24h
> >  Remaining Estimate: 24h
> >
> > org.apache.pig.builtin.CONCAT (which acts on DataByteArray's internally)
> and org.apache.pig.builtin.StringConcat (which acts on Strings internally),
> both act on the first two fields of a tuple.  This results in ugly nested
> CONCAT calls like:
> > CONCAT(CONCAT(A, ' '), B)
> > The more desirable form is:
> > CONCAT(A, ' ', B)
> > This change will be backwards compatible, provided that no one was
> relying on the fact that CONCAT ignores fields after the first two in a
> tuple.  This seems a reasonable assumption to make, or at least a small
> break in compatibility for a sizable improvement.
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
>