Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Sqoop >> mail # dev >> Re: Review Request 10964: SQOOP-927 Sqoop2: Integration: Mapreduce specific tests should be running on MiniCluster


Copy link to this message
-
Re: Review Request 10964: SQOOP-927 Sqoop2: Integration: Mapreduce specific tests should be running on MiniCluster


> On Aug. 23, 2013, 11:24 p.m., Jarek Cecho wrote:
> > dist/src/main/server/conf/catalina.properties, line 47
> > <https://reviews.apache.org/r/10964/diff/7/?file=341604#file341604line47>
> >
> >     Is this change relevant for the patch?

No. Sorry. I have to add that every time to test Sqoop. I'll remove it.
> On Aug. 23, 2013, 11:24 p.m., Jarek Cecho wrote:
> > test/pom.xml, line 120
> > <https://reviews.apache.org/r/10964/diff/7/?file=341606#file341606line120>
> >
> >     Setting the timeout to 0 might be quite dangerous especially when running on Jenkins. Would it be possible to set here some high, but still finite number?

Sure, I'll set it to 1 hour.
> On Aug. 23, 2013, 11:24 p.m., Jarek Cecho wrote:
> > test/src/main/java/org/apache/sqoop/test/hadoop/HadoopMiniClusterRunner.java, lines 71-72
> > <https://reviews.apache.org/r/10964/diff/7/?file=341609#file341609line71>
> >
> >     Nit: Wouldn't make sense to log "Stopping" and then start stopping the service?

I think you mean "Stopping..." then "Stopped"?
> On Aug. 23, 2013, 11:24 p.m., Jarek Cecho wrote:
> > test/src/main/java/org/apache/sqoop/test/hadoop/HadoopMiniClusterRunner.java, lines 74-75
> > <https://reviews.apache.org/r/10964/diff/7/?file=341609#file341609line74>
> >
> >     Nit: Wouldn't make sense to log "Stopping" and then start stopping the service?

same as above
- Abraham
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10964/#review25479
-----------------------------------------------------------
On Aug. 16, 2013, 12:17 a.m., Abraham Elmahrek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10964/
> -----------------------------------------------------------
>
> (Updated Aug. 16, 2013, 12:17 a.m.)
>
>
> Review request for Sqoop and Jarek Cecho.
>
>
> Bugs: SQOOP-927
>     https://issues.apache.org/jira/browse/SQOOP-927
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> commit ff7dba55a09dd7789a34136233000c625759e583
> Author: Abraham Elmahrek <[EMAIL PROTECTED]>
> Date:   Fri Apr 26 15:10:24 2013 -0700
>
>     SQOOP-927 Sqoop2: Integration: Mapreduce specific tests should be running on MiniCluster
>    
>     Handle MiniDFSCluster and MiniMRClientCluster on own.
>    
>     Set yarn.application.classpath to get over classpath errors.
>     Set to use fair scheduler.
>
> :100644 100644 0abbb18... f09704b... M pom.xml
> :100644 100644 6eb3184... a4c2a5b... M test/src/test/java/org/apache/sqoop/integration/TomcatTestCase.java
> :100644 100644 0f48a8b... 758c885... M test/src/test/java/org/apache/sqoop/integration/server/VersionTest.java
>
>
> Diffs
> -----
>
>   dist/src/main/server/conf/catalina.properties 5a47295d6e1bfa2114f86d620bb1452bc576df71
>   pom.xml 513b6d0570ee6f1ec32f8c35a403becc1cfa156a
>   test/pom.xml 8001fcec29bf5a7d9c3119b9f6ef548f678e1ebe
>   test/src/main/java/org/apache/sqoop/test/asserts/HdfsAsserts.java c17527285167104994d78f5919b7f11c0c31cd15
>   test/src/main/java/org/apache/sqoop/test/hadoop/HadoopLocalRunner.java PRE-CREATION
>   test/src/main/java/org/apache/sqoop/test/hadoop/HadoopMiniClusterRunner.java PRE-CREATION
>   test/src/main/java/org/apache/sqoop/test/hadoop/HadoopRunner.java PRE-CREATION
>   test/src/main/java/org/apache/sqoop/test/hadoop/HadoopRunnerFactory.java PRE-CREATION
>   test/src/main/java/org/apache/sqoop/test/testcases/ConnectorTestCase.java d10b94268babeb3dc7b1d2450776af5fd8449fd3
>   test/src/main/java/org/apache/sqoop/test/testcases/TomcatTestCase.java efdfed4e2065c0c01c16da88cf55705ab13d7bcf
>   test/src/main/java/org/apache/sqoop/test/utils/HdfsUtils.java 95dd177a11c5d822e35ca54e5d93785f0a40fbfc
>
> Diff: https://reviews.apache.org/r/10964/diff/
>
>
> Testing
> -------
>
> Ran integration tests without and with miniclusters.
> Currently need to use both miniclusters or neither for tests to work.