Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Plain View
Sqoop >> mail # dev >> Re: Review Request 8559: Add Accumulo support to Sqoop


+
Philip Grim 2013-10-23, 21:24
+
Philip Grim 2013-10-23, 21:24
+
Sean Busbey 2013-10-24, 17:09
+
Sean Busbey 2013-11-02, 16:01
+
Philip Grim 2013-11-01, 15:41
+
Sean Busbey 2013-11-02, 17:04
+
Philip Grim 2013-11-11, 15:31
Copy link to this message
-
Re: Review Request 8559: Add Accumulo support to Sqoop

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8559/#review28593
-----------------------------------------------------------
Hi Philip,
I was playing with the patch a bit and I have to say, very good job! Unit tests in all profiles are passing, which is great. I'm still trying to test the patch on a real Hadoop/Accumulo cluster. I'll keep you posted about my progress there. Couple of notes that I've noticed:

1) You've put together great docs that are very easy to follow, thank you! They are however not being included in user guide as they are referenced anywhere. Would you mind ensuring that the docs will get propagated into the User guide as well? You can use command ant docs to generate the User guide.

2) For Hive and HBase import we do have special bash code in the loading scripts that are ensuring that all the required dependencies are on classpath. Would you mind providing similar solution for Accumulo, so that users don't have to hack the classpath together themselves?
src/java/org/apache/sqoop/tool/BaseSqoopTool.java
<https://reviews.apache.org/r/8559/#comment55439>

    Seems like unused import.
Jarcec

- Jarek Cecho
On Nov. 11, 2013, 3:31 p.m., Philip Grim wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8559/
> -----------------------------------------------------------
>
> (Updated Nov. 11, 2013, 3:31 p.m.)
>
>
> Review request for accumulo, Sqoop and Jarek Cecho.
>
>
> Repository: sqoop-trunk
>
>
> Description
> -------
>
> Adds the ability to import to an Accumulo table in much the same manner as the current HBase import capability.  Reported in JIRA as ACCUMULO-141 and SQOOP-767.
>
>
> Diffs
> -----
>
>   ivy.xml c5130ae
>   src/docs/user/accumulo-args.txt PRE-CREATION
>   src/docs/user/accumulo.txt PRE-CREATION
>   src/java/org/apache/sqoop/SqoopOptions.java 5c7a56a
>   src/java/org/apache/sqoop/accumulo/AccumuloConstants.java PRE-CREATION
>   src/java/org/apache/sqoop/accumulo/AccumuloMutationProcessor.java PRE-CREATION
>   src/java/org/apache/sqoop/accumulo/AccumuloUtil.java PRE-CREATION
>   src/java/org/apache/sqoop/accumulo/MutationTransformer.java PRE-CREATION
>   src/java/org/apache/sqoop/accumulo/ToStringMutationTransformer.java PRE-CREATION
>   src/java/org/apache/sqoop/manager/SqlManager.java 1ffa40f
>   src/java/org/apache/sqoop/mapreduce/AccumuloImportJob.java PRE-CREATION
>   src/java/org/apache/sqoop/mapreduce/AccumuloImportMapper.java PRE-CREATION
>   src/java/org/apache/sqoop/tool/BaseSqoopTool.java 018d11f
>   src/java/org/apache/sqoop/tool/ImportTool.java fbbde1d
>   src/test/org/apache/sqoop/accumulo/AccumuloTestCase.java PRE-CREATION
>   src/test/org/apache/sqoop/accumulo/TestAccumuloImport.java PRE-CREATION
>   src/test/org/apache/sqoop/accumulo/TestAccumuloQueryImport.java PRE-CREATION
>   src/test/org/apache/sqoop/accumulo/TestAccumuloUtil.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/8559/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Philip Grim
>
>

+
Philip Grim 2013-11-18, 22:15
+
Philip Grim 2013-11-18, 22:16
+
Philip Grim 2013-11-19, 23:06
+
Jarek Cecho 2013-11-19, 21:02
+
Philip Grim 2013-11-19, 23:05
+
Jarek Cecho 2013-11-07, 23:56