Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Flume >> mail # dev >> Review Request: FLUME-1828: ResettableInputStream should support seek()


Copy link to this message
-
Re: Review Request: FLUME-1828: ResettableInputStream should support seek()

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8926/
-----------------------------------------------------------

(Updated Jan. 12, 2013, 12:34 a.m.)
Review request for Flume.
Description
-------

ResettableInputStream should support seek().

This patch makes ResettableInputStream an abstract class instead of an interface, and adds a Seekable interface which is implemented by ResettableInputStream and its subclasses.
This addresses bug FLUME-1828.
    https://issues.apache.org/jira/browse/FLUME-1828
Diffs
-----

  flume-ng-core/src/main/java/org/apache/flume/serialization/ResettableFileInputStream.java f9e4ec9
  flume-ng-core/src/main/java/org/apache/flume/serialization/ResettableInputStream.java ae989a6
  flume-ng-core/src/main/java/org/apache/flume/serialization/Seekable.java PRE-CREATION
  flume-ng-core/src/test/java/org/apache/flume/serialization/ResettableTestStringInputStream.java ef8b7ba
  flume-ng-core/src/test/java/org/apache/flume/serialization/TestResettableFileInputStream.java 73e2baa

Diff: https://reviews.apache.org/r/8926/diff/
Testing (updated)
-------

Added unit test for seek(). Unit tests pass.
Thanks,

Mike Percy