It seems to me that a major_compact table command from hbase shell do not fush memstore?  When I done with major compact, still some data in memstore and will be flush out to disk when I shut down hbase cluster.

Best Regards,
Raymond Liu

Did you try from java api?  If flush does not happen we may need to fix it.

Regards
RAm

On Tue, Mar 12, 2013 at 1:04 PM, Liu, Raymond <[EMAIL PROTECTED]> wrote:

> It seems to me that a major_compact table command from hbase shell do not
> fush memstore?  When I done with major compact, still some data in memstore
> and will be flush out to disk when I shut down hbase cluster.
>
> Best Regards,
> Raymond Liu
>
>

I tried both hbase shell's major_compact cmd and java api HBaseAdmin.majorCompact() on table name.
They don't flush the memstore on to disk, compact cmd seems not doing that too.

I hadn't read enough related code, While I am wondering, is that because there are size threshold before a memstore is flushed? Then a user invoked compact don't force to flush it?

Best Regards,
Raymond Liu

>
> Did you try from java api?  If flush does not happen we may need to fix it.
>
> Regards
> RAm
>
> On Tue, Mar 12, 2013 at 1:04 PM, Liu, Raymond <[EMAIL PROTECTED]>
> wrote:
>
> > It seems to me that a major_compact table command from hbase shell do
> > not fush memstore?  When I done with major compact, still some data in
> > memstore and will be flush out to disk when I shut down hbase cluster.
> >
> > Best Regards,
> > Raymond Liu
> >
> >

Raymond:

Major compaction does not first flush.  Should it or should it be an option?

St.Ack
On Tue, Mar 12, 2013 at 6:46 PM, Liu, Raymond <[EMAIL PROTECTED]> wrote:

> I tried both hbase shell's major_compact cmd and java api
> HBaseAdmin.majorCompact() on table name.
> They don't flush the memstore on to disk, compact cmd seems not doing that
> too.
>
> I hadn't read enough related code, While I am wondering, is that because
> there are size threshold before a memstore is flushed? Then a user invoked
> compact don't force to flush it?
>
> Best Regards,
> Raymond Liu
>
> >
> > Did you try from java api?  If flush does not happen we may need to fix
> it.
> >
> > Regards
> > RAm
> >
> > On Tue, Mar 12, 2013 at 1:04 PM, Liu, Raymond <[EMAIL PROTECTED]>
> > wrote:
> >
> > > It seems to me that a major_compact table command from hbase shell do
> > > not fush memstore?  When I done with major compact, still some data in
> > > memstore and will be flush out to disk when I shut down hbase cluster.
> > >
> > > Best Regards,
> > > Raymond Liu
> > >
> > >
>

St.Ack

I am not sure what's the design idea behind it. While, If I want to invoke a major compact manually, I guess what I want is that all separate file and the memstore is combined into one file. If I don't write anything new there, from the user point of view, I will assume that it will end up in a single store file per region.
Best Regards,
Raymond Liu

>
> Raymond:
>
> Major compaction does not first flush.  Should it or should it be an option?
>
> St.Ack
>
>
> On Tue, Mar 12, 2013 at 6:46 PM, Liu, Raymond <[EMAIL PROTECTED]>
> wrote:
>
> > I tried both hbase shell's major_compact cmd and java api
> > HBaseAdmin.majorCompact() on table name.
> > They don't flush the memstore on to disk, compact cmd seems not doing
> > that too.
> >
> > I hadn't read enough related code, While I am wondering, is that
> > because there are size threshold before a memstore is flushed? Then a
> > user invoked compact don't force to flush it?
> >
> > Best Regards,
> > Raymond Liu
> >
> > >
> > > Did you try from java api?  If flush does not happen we may need to
> > > fix
> > it.
> > >
> > > Regards
> > > RAm
> > >
> > > On Tue, Mar 12, 2013 at 1:04 PM, Liu, Raymond
> > > <[EMAIL PROTECTED]>
> > > wrote:
> > >
> > > > It seems to me that a major_compact table command from hbase shell
> > > > do not fush memstore?  When I done with major compact, still some
> > > > data in memstore and will be flush out to disk when I shut down hbase
> cluster.
> > > >
> > > > Best Regards,
> > > > Raymond Liu
> > > >
> > > >
> >