Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Hive >> mail # dev >> Review Request: New code to implement vectorized Scalar-Column arithmetic expression evaluation


Copy link to this message
-
Re: Review Request: New code to implement vectorized Scalar-Column arithmetic expression evaluation

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10706/#review19537
-----------------------------------------------------------

Ship it!
Ship It!

- Ashutosh Chauhan
On April 22, 2013, 4:50 p.m., Eric Hanson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10706/
> -----------------------------------------------------------
>
> (Updated April 22, 2013, 4:50 p.m.)
>
>
> Review request for hive.
>
>
> Description
> -------
>
> New code to implement vectorized Scalar-Column arithmetic expression evaluation.
>
> Several of the files are generated from templates/ScalarArithmeticColumn.txt. For easiest review, just have a look over the template, and review one of the generated files, say gen/LongScalarSubtractLongColumn.java. No need to review all the generated files. We plan to change the build system so the generated files don't get checked in at some point in the future.
>
>
> This addresses bug HIVE-4380.
>     https://issues.apache.org/jira/browse/HIVE-4380
>
>
> Diffs
> -----
>
>   ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/gen/DoubleScalarAddDoubleColumn.java PRE-CREATION
>   ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/gen/DoubleScalarAddLongColumn.java PRE-CREATION
>   ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/gen/DoubleScalarDivideDoubleColumn.java PRE-CREATION
>   ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/gen/DoubleScalarDivideLongColumn.java PRE-CREATION
>   ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/gen/DoubleScalarModuloDoubleColumn.java PRE-CREATION
>   ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/gen/DoubleScalarModuloLongColumn.java PRE-CREATION
>   ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/gen/DoubleScalarMultiplyDoubleColumn.java PRE-CREATION
>   ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/gen/DoubleScalarMultiplyLongColumn.java PRE-CREATION
>   ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/gen/DoubleScalarSubtractDoubleColumn.java PRE-CREATION
>   ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/gen/DoubleScalarSubtractLongColumn.java PRE-CREATION
>   ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/gen/LongScalarAddDoubleColumn.java PRE-CREATION
>   ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/gen/LongScalarAddLongColumn.java PRE-CREATION
>   ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/gen/LongScalarDivideDoubleColumn.java PRE-CREATION
>   ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/gen/LongScalarDivideLongColumn.java PRE-CREATION
>   ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/gen/LongScalarModuloDoubleColumn.java PRE-CREATION
>   ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/gen/LongScalarModuloLongColumn.java PRE-CREATION
>   ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/gen/LongScalarMultiplyDoubleColumn.java PRE-CREATION
>   ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/gen/LongScalarMultiplyLongColumn.java PRE-CREATION
>   ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/gen/LongScalarSubtractDoubleColumn.java PRE-CREATION
>   ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/gen/LongScalarSubtractLongColumn.java PRE-CREATION
>   ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/templates/CodeGen.java d6f45d3
>   ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/templates/ScalarArithmeticColumn.txt PRE-CREATION
>   ql/src/test/org/apache/hadoop/hive/ql/exec/vector/expressions/TestVectorScalarColArithmetic.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/10706/diff/
>
>
> Testing
> -------
>