Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Sqoop, mail # dev - Review Request 16112: SQOOP-1258 Sqoop2: FrameworkMetadataUpgrade can't handle new inputs


Copy link to this message
-
Re: Review Request 16112: SQOOP-1258 Sqoop2: FrameworkMetadataUpgrade can't handle new inputs
Hari Shreedharan 2013-12-09, 00:02

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16112/#review29969
-----------------------------------------------------------
Jarcec,

This looks good. Would it be possible to add a unit test to this one please?

- Hari Shreedharan
On Dec. 8, 2013, 11:52 p.m., Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16112/
> -----------------------------------------------------------
>
> (Updated Dec. 8, 2013, 11:52 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-1258
>     https://issues.apache.org/jira/browse/SQOOP-1258
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> I've fixed the issue by providing try-catch block as is done in the GenericJDBCConnector upgrader.
>
>
> Diffs
> -----
>
>   connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnectorMetadataUpgrader.java 864426c
>   core/src/main/java/org/apache/sqoop/framework/FrameworkMetadataUpgrader.java ef00780
>
> Diff: https://reviews.apache.org/r/16112/diff/
>
>
> Testing
> -------
>
> Tested on real cluster as a part of testing SQOOP-1254. I'm not attaching new unit tests as I would like to refactore the Upgraders a bit after this and SQOOP-1254 gets committed.
>
>
> Thanks,
>
> Jarek Cecho
>
>