Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Plain View
Hive, mail # dev - Review Request 15113: HIVE-5356: Move arithmatic UDFs to generic UDF implementations


+
Xuefu Zhang 2013-10-31, 05:43
+
Jason Dere 2013-11-01, 01:45
+
Xuefu Zhang 2013-11-01, 01:56
+
Xuefu Zhang 2013-11-02, 03:43
+
Xuefu Zhang 2013-11-03, 19:26
+
Jason Dere 2013-11-05, 19:28
+
Jason Dere 2013-11-04, 22:56
+
Xuefu Zhang 2013-11-13, 15:04
+
Xuefu Zhang 2013-11-13, 15:04
+
Xuefu Zhang 2013-11-13, 15:33
+
Xuefu Zhang 2013-11-13, 15:34
+
Xuefu Zhang 2013-11-13, 15:35
+
Xuefu Zhang 2013-11-13, 15:35
+
Xuefu Zhang 2013-11-13, 15:36
+
Xuefu Zhang 2013-11-13, 15:36
+
Xuefu Zhang 2013-11-13, 15:33
+
Xuefu Zhang 2013-11-14, 20:44
+
Jason Dere 2013-11-14, 21:32
+
Xuefu Zhang 2013-11-14, 21:37
+
Xuefu Zhang 2013-11-14, 22:11
Copy link to this message
-
Re: Review Request 15113: HIVE-5356: Move arithmatic UDFs to generic UDF implementations
Brock Noland 2013-11-15, 18:13

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15113/#review28976
-----------------------------------------------------------
Nice!! Looks good to me and it appears there are new unit tests! Some minor questions and comments below as well as two minor issues.
ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java
<https://reviews.apache.org/r/15113/#comment56029>

    I see there are utilities in here prior to this patch so no work to do here but Function Registry doesn't feel like the right place to have these utilities.

ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFBaseNumeric.java
<https://reviews.apache.org/r/15113/#comment56031>

    I assume these aren't final due to serialization. If so, it might be worth a comment indicating so.

ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFBaseNumeric.java
<https://reviews.apache.org/r/15113/#comment56030>

    It looks like all these methods are going to be overridden by each sub-class? If that is true then they should be abstract with no body.

serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/HiveDecimalUtils.java
<https://reviews.apache.org/r/15113/#comment56035>

    Should these be constants in common or some shared location so jdbc and serde would share the same value?
- Brock Noland
On Nov. 14, 2013, 10:11 p.m., Xuefu Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15113/
> -----------------------------------------------------------
>
> (Updated Nov. 14, 2013, 10:11 p.m.)
>
>
> Review request for hive.
>
>
> Bugs: HIVe-5356
>     https://issues.apache.org/jira/browse/HIVe-5356
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Replace plus, minus, and so on 6 old UDFs with generic UDF implementations.
>
>
> Diffs
> -----
>
>   common/src/test/org/apache/hadoop/hive/common/type/TestHiveDecimal.java e3a1620
>   ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java 5eb321c
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/Vectorizer.java 7c1ab0d
>   ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java 7838547
>   ql/src/java/org/apache/hadoop/hive/ql/udf/UDFBaseNumericOp.java 1e74fce
>   ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPDivide.java b892b84
>   ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPMinus.java 0996231
>   ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPMod.java 0942ac3
>   ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPMultiply.java 07c1957
>   ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPPlus.java cfe7b2b
>   ql/src/java/org/apache/hadoop/hive/ql/udf/UDFPosMod.java 0da7eae
>   ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFBaseNumeric.java PRE-CREATION
>   ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPDivide.java PRE-CREATION
>   ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPMinus.java PRE-CREATION
>   ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPMod.java PRE-CREATION
>   ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPMultiply.java PRE-CREATION
>   ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPPlus.java PRE-CREATION
>   ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFPosMod.java PRE-CREATION
>   ql/src/test/org/apache/hadoop/hive/ql/exec/vector/TestVectorSelectOperator.java 4aeb4e6
>   ql/src/test/org/apache/hadoop/hive/ql/exec/vector/TestVectorizationContext.java 3f3e67f
>   ql/src/test/org/apache/hadoop/hive/ql/udf/TestUDFOPDivide.java 659d65f
>   ql/src/test/org/apache/hadoop/hive/ql/udf/TestUDFOPMod.java 4c2e722
>   ql/src/test/org/apache/hadoop/hive/ql/udf/TestUDFPosMod.java 2a301bc
>   ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFOPDivide.java PRE-CREATION
>   ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFOPMinus.java PRE-CREATION
+
Xuefu Zhang 2013-11-17, 04:32