Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Sqoop >> mail # dev >> Review Request 13181: SQOOP-773 Sqoop2: Batch execution support for client commands


Copy link to this message
-
Re: Review Request 13181: SQOOP-773 Sqoop2: Batch execution support for client commands

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13181/#review26935
-----------------------------------------------------------
Hi Abe,
thank you very much for working on the patch, appreciated! I've tested it in my environment and I do have couple of notes:

I think that we need to ensure that one failed command will end entire script execution. I'm thinking about use case that would do the following:

1) create connection
2) create job for -^
3) run the job -^

In such situation we need to ensure that we are not creating job for non-existing connection or running non-existing job.
shell/src/main/java/org/apache/sqoop/shell/CloneConnectionFunction.java
<https://reviews.apache.org/r/13181/#comment52475>

    Can we make this and similar code a bit more verbose?
    
    I've tried following script:
    
    create connection --cid 1 --name NameX
    
    And I got following output:
    
    [root@bousa-trunk sqoop]# ./bin/sqoop.sh client create.sqoop
    Sqoop home directory: /root/sqoop
    sqoop:000> create connection --cid 1 --name NameX
    Creating connection for connector with id 1
    [root@bousa-trunk sqoop]#
    
    Creating the connection has failed as I did not specified any arguments, but there is no error message which is really confusing.

shell/src/main/java/org/apache/sqoop/shell/SqoopFunction.java
<https://reviews.apache.org/r/13181/#comment52464>

    It seems that some of the functions are just returning true and not doing any validations. What about making such function default here and let the children override it only if some validations will be required?

shell/src/main/java/org/apache/sqoop/shell/utils/FormOptions.java
<https://reviews.apache.org/r/13181/#comment52462>

    Nit: Unused import.
Jarcec

- Jarek Cecho
On Sept. 27, 2013, 6:30 p.m., Abraham Elmahrek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13181/
> -----------------------------------------------------------
>
> (Updated Sept. 27, 2013, 6:30 p.m.)
>
>
> Review request for Sqoop, Hari Shreedharan and Jarek Cecho.
>
>
> Bugs: SQOOP-773
>     https://issues.apache.org/jira/browse/SQOOP-773
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> commit 080ced16578c1d95015ce3e99b4335beb465861a
> Author: Abraham Elmahrek <[EMAIL PROTECTED]>
> Date:   Tue Aug 13 14:14:06 2013 -0700
>
>     SQOOP-773 Sqoop2: Batch execution support for client commands
>    
>     Separated options into two groups: fixed and dynamic options.
>     Fixed options (IE: connector ID) come first and are used to select
>     what options should be used in dynamic options. Dynamic options
>     are automatically created based on forms selected from fixed options.
>     The keys for these options take on the form "<prefix>-<form name>-<input-name>".
>
> :100644 100644 980a908... a7e7e7d... M  shell/src/main/java/org/apache/sqoop/shell/CloneCommand.java
> :100644 100644 856abaa... 2c2869c... M  shell/src/main/java/org/apache/sqoop/shell/CloneConnectionFunction.java
> :100644 100644 3e23025... dd2eb2b... M  shell/src/main/java/org/apache/sqoop/shell/CloneJobFunction.java
> :100644 100644 e62ce08... 9ad007b... M  shell/src/main/java/org/apache/sqoop/shell/CreateCommand.java
> :100644 100644 5fbf0a3... 973fd53... M  shell/src/main/java/org/apache/sqoop/shell/CreateConnectionFunction.java
> :100644 100644 6e4f04b... f0d4a6c... M  shell/src/main/java/org/apache/sqoop/shell/CreateJobFunction.java
> :100644 100644 c123732... d79516d... M  shell/src/main/java/org/apache/sqoop/shell/DeleteConnectionFunction.java
> :100644 100644 d4095b7... df9a2cc... M  shell/src/main/java/org/apache/sqoop/shell/DeleteJobFunction.java
> :100644 100644 f119660... b5a54b9... M  shell/src/main/java/org/apache/sqoop/shell/DisableConnectionFunction.java