Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Sqoop >> mail # dev >> Review Request: Securing passwords in sqoop 1.x

Copy link to this message
Re: Review Request: Securing passwords in sqoop 1.x

This is an automatically generated e-mail. To reply, visit:

(Updated March 13, 2013, 9:41 p.m.)
Review request for Sqoop and Jarek Cecho.

Thanks Jarek for your time in reviewing the patch. Very good catch on the metastore storing passwords and I had inadvertently missed this feature. This revision incorporates all the review comments so far from Jarek. Thanks again!

An attempt to add a way for users to pass credentials to sqoop in a secure way by storing the password in a file under user's home directory with 400 permissions.
This addresses bug https://issues.apache.org/jira/browse/SQOOP-914.
Diffs (updated)

  src/docs/man/common-args.txt cf9c0c3
  src/docs/user/common-args.txt 0554f81
  src/docs/user/connecting.txt 44a5111
  src/docs/user/help.txt 24fbddc
  src/docs/user/tools.txt 96bf777
  src/java/org/apache/sqoop/SqoopOptions.java addc889
  src/java/org/apache/sqoop/mapreduce/db/DBConfiguration.java d270bc8
  src/java/org/apache/sqoop/tool/BaseSqoopTool.java 684d4a5
  src/java/org/apache/sqoop/util/CredentialsUtil.java PRE-CREATION
  src/test/org/apache/sqoop/credentials/TestPassingSecurePassword.java PRE-CREATION

Diff: https://reviews.apache.org/r/9771/diff/

Adds unit tests. All unit tests pass and checkstyle issues fixed.

Seetharam Venkatesh