Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Sqoop, mail # dev - Review Request 13035: SQOOP-744: log4j configuration for generated mapreduce job


Copy link to this message
-
Re: Review Request 13035: SQOOP-744: log4j configuration for generated mapreduce job
Jarek Cecho 2013-07-30, 01:10

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13035/#review24193
-----------------------------------------------------------
Hi Raghav,
thank you for working on this JIRA! It seems that the logger is being configured only from Mapper and Reducer, so I'm wondering if there is reason why other top level entities (Input and Output formats for example) were skipped?
execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/ConfigurationUtils.java
<https://reviews.apache.org/r/13035/#comment48030>

    Ignoring exceptions is usually not a good thing to do. I do understand that we can't use logger as this method is initializing the logging and failure means that the logger is not available, but perhaps we can use System.err?
Jarcec

- Jarek Cecho
On July 29, 2013, 10:32 p.m., Raghav Gautam wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13035/
> -----------------------------------------------------------
>
> (Updated July 29, 2013, 10:32 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-744
>     https://issues.apache.org/jira/browse/SQOOP-744
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> Adding log4j.properties for the generated job.
>
>
> Diffs
> -----
>
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/ConfigurationUtils.java f5f6d8e
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopMapper.java 59cf391
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopReducer.java b31161c
>   execution/mapreduce/src/main/resources/META-INF/log4j.properties PRE-CREATION
>
> Diff: https://reviews.apache.org/r/13035/diff/
>
>
> Testing
> -------
>
> Manually tested.
>
>
> Thanks,
>
> Raghav Gautam
>
>