Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Sqoop, mail # dev - Review Request 12774: Fix for SQOOP-1075: Persist framework version in repository


Copy link to this message
-
Re: Review Request 12774: Fix for SQOOP-1075: Persist framework version in repository
Raghav Gautam 2013-07-29, 22:57

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12774/
-----------------------------------------------------------

(Updated July 29, 2013, 3:57 p.m.)
Review request for Sqoop.
Changes
-------

Hi Jarek, I have rebased my patch and unit tests look good. Sorry for the trouble.
Bugs: SQOOP-1075
    https://issues.apache.org/jira/browse/SQOOP-1075
Repository: sqoop-sqoop2
Description
-------

A summary of changes:
1. MFramework: added fields, getter & setter method for version. Made changes to other methods to take version into account.
2. MConnector: since it extends MFramework, can use his version field and methods
3. FrameworkBean, FormSerialization: encode/decode version field to json
4. DerbyRepositoryHandler, DerbyRepoError: added private methods to persist/fetch framework version; update framework version when registering/updating framework
5. TestFrameworkHandling: added test - the test checks for current version of framework, changes it to lower version updates the framework and checks the version of framework once again
6. TestSqoopClient, TestUtils, TestMFramework, FrameworkManager, DerbyTestCase: added version parameter to the MFramework constructor call.
Diffs (updated)
-----

  client/src/test/java/org/apache/sqoop/client/TestSqoopClient.java 1778cf1
  common/src/main/java/org/apache/sqoop/json/FrameworkBean.java ad4753b
  common/src/main/java/org/apache/sqoop/json/util/FormSerialization.java 978789b
  common/src/main/java/org/apache/sqoop/model/MConnector.java 1c2c422
  common/src/main/java/org/apache/sqoop/model/MFramework.java 694f022
  common/src/test/java/org/apache/sqoop/json/TestUtil.java b88d7a4
  common/src/test/java/org/apache/sqoop/model/TestMFramework.java a5366ca
  core/src/main/java/org/apache/sqoop/framework/FrameworkManager.java ad6cd0f
  core/src/test/java/org/apache/sqoop/repository/TestJdbcRepository.java 247e165
  repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepoConstants.java 607b8d5
  repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepoError.java 455eb64
  repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java 771673d
  repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java b766b09
  repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestFrameworkHandling.java 66611d4

Diff: https://reviews.apache.org/r/12774/diff/
Testing
-------

I have added new tests.
All the unit tests are passing.
Thanks,

Raghav Gautam