Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Pig, mail # dev - Uploading patches for review


Copy link to this message
-
Uploading patches for review
Rohini Palaniswamy 2013-06-06, 01:21
Hi,
    Reviewing uploaded patches for few lines of change is easy. But when
the change is more it is hard to read, review is more time consuming and at
times you have to switch between the patch and eclipse to get more context.
Without the surrounding code it is also easy to miss things on review. Can
we make it a practice and decide on putting up the patches in review board
for review if it is slightly bigger? Commenting on the patch is also a
breeze in the review board.

Thoughts ???

Regards,
Rohini