Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Plain View
Sqoop, mail # dev - Review Request 12713: SQOOP-1142 Sqoop2: Provide creater and last edited by to metadata structures


+
Mengwei Ding 2013-07-17, 22:33
+
Mengwei Ding 2013-07-18, 17:09
+
Jarek Cecho 2013-07-21, 16:38
+
Mengwei Ding 2013-07-22, 17:27
+
Mengwei Ding 2013-07-22, 17:27
+
Mengwei Ding 2013-07-22, 17:33
Copy link to this message
-
Re: Review Request 12713: SQOOP-1142 Sqoop2: Provide creater and last edited by to metadata structures
Mengwei Ding 2013-07-22, 17:29


> On July 21, 2013, 4:38 p.m., Jarek Cecho wrote:
> > common/src/main/java/org/apache/sqoop/model/MAccountableEntity.java, line 41
> > <https://reviews.apache.org/r/12713/diff/2/?file=323237#file323237line41>
> >
> >     Nit: The phrase "last update by" seems weird. I would either suggest to say "last updated by" or "last update author/person/user/noun".

Yes, I thought about this before. The thing is that there is also another Date variable called "lastUpdateDate", so I just followed the naming.
- Mengwei
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12713/#review23595
-----------------------------------------------------------
On July 18, 2013, 5:09 p.m., Mengwei Ding wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12713/
> -----------------------------------------------------------
>
> (Updated July 18, 2013, 5:09 p.m.)
>
>
> Review request for Sqoop, Abraham Elmahrek, Hari Shreedharan, and Jarek Cecho.
>
>
> Bugs: SQOOP-1142
>     https://issues.apache.org/jira/browse/SQOOP-1142
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> commit d1cca7f5283847096dec27134edf56804f07e96d
> Author: Mengwei Ding <[EMAIL PROTECTED]>
> Date:   Wed Jul 17 10:48:05 2013 -0700
>
>     SQOOP-1142 Sqoop2: Provide creater and last edited by to metadata structures
>
> :100644 100644 b7b0436... a7a748b... M client/src/main/java/org/apache/sqoop/client/core/Constants.java
> :100644 100644 32bca71... 13b2475... M client/src/main/java/org/apache/sqoop/client/shell/ShowConnectionFunction.java
> :100644 100644 590e4e7... 70111e3... M client/src/main/java/org/apache/sqoop/client/shell/ShowJobFunction.java
> :100644 100644 cbc956d... a7343d4... M client/src/main/java/org/apache/sqoop/client/utils/SubmissionDisplayer.java
> :100644 100644 5537a8e... 5f077ea... M client/src/main/resources/client-resource.properties
> :100644 100644 b4e986a... c452662... M common/src/main/java/org/apache/sqoop/json/ConnectionBean.java
> :100644 100644 a830646... fddeb06... M common/src/main/java/org/apache/sqoop/json/JobBean.java
> :100644 100644 79490f8... 6efc8a0... M common/src/main/java/org/apache/sqoop/json/SubmissionBean.java
> :100644 100644 98768d6... ed604de... M common/src/main/java/org/apache/sqoop/json/util/FormSerialization.java
> :100644 100644 137e71c... 7db8d98... M common/src/main/java/org/apache/sqoop/model/MAccountableEntity.java
> :100644 100644 dd1d75b... 49cb300... M common/src/test/java/org/apache/sqoop/json/TestConnectionBean.java
> :100644 100644 3b56171... bfcaffa... M common/src/test/java/org/apache/sqoop/json/TestSubmissionBean.java
> :100644 100644 4ea42b1... 7d96468... M common/src/test/java/org/apache/sqoop/model/TestMAccountableEntity.java
> :100644 100644 9f09982... c267b7b... M core/src/main/java/org/apache/sqoop/framework/JobManager.java
> :100644 100644 f717abf... 9ba67d2... M repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java
> :100644 100644 68cb1c0... 413c188... M repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java
> :100644 100644 b2cd6cc... 99dc3b1... M repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java
> :100644 100644 038f602... 456cbb8... M server/src/main/java/org/apache/sqoop/handler/ConnectionRequestHandler.java
> :100644 100644 ab3f9d0... d82ad08... M server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java
> :100644 100644 65686a8... 73a01e1... M server/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.java
>
>
> Diffs
> -----
>
>   client/src/main/java/org/apache/sqoop/client/core/Constants.java b7b0436
>   client/src/main/java/org/apache/sqoop/client/shell/ShowConnectionFunction.java 32bca71
>   client/src/main/java/org/apache/sqoop/client/shell/ShowJobFunction.java 590e4e7
+
Mengwei Ding 2013-07-22, 21:36
+
Mengwei Ding 2013-07-23, 18:44
+
Mengwei Ding 2013-07-24, 17:55
+
Jarek Cecho 2013-07-28, 15:43
+
Mengwei Ding 2013-08-02, 21:37
+
Mengwei Ding 2013-08-02, 21:36
+
Mengwei Ding 2013-08-14, 17:32
+
Mengwei Ding 2013-08-14, 20:42
+
Jarek Cecho 2013-08-14, 22:27
+
Jarek Cecho 2013-08-14, 20:12
+
Jarek Cecho 2013-08-14, 01:00