-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6861/
-----------------------------------------------------------

Review request for accumulo.
Description
-------

A patch for adding quoting to column visibility
Diffs
-----

  /trunk/core/src/main/java/org/apache/accumulo/core/security/Authorizations.java 1379035
  /trunk/core/src/main/java/org/apache/accumulo/core/security/ColumnVisibility.java 1379035
  /trunk/core/src/main/java/org/apache/accumulo/core/security/VisibilityEvaluator.java 1379035
  /trunk/core/src/test/java/org/apache/accumulo/core/security/ColumnVisibilityTest.java 1379035
  /trunk/core/src/test/java/org/apache/accumulo/core/security/VisibilityEvaluatorTest.java 1379035

Diff: https://reviews.apache.org/r/6861/diff/
Testing
-------
Thanks,

kturner

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6861/#review10916
-----------------------------------------------------------

/trunk/core/src/main/java/org/apache/accumulo/core/security/ColumnVisibility.java
<https://reviews.apache.org/r/6861/#comment23448>

    I think it would be better to escape the authorizations only once per scan (per tablet server), and compare the escaped versions as terms, rather than unescape each term for comparison.
- Christopher Tubbs
On Aug. 30, 2012, 8:59 p.m., kturner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6861/
> -----------------------------------------------------------
>
> (Updated Aug. 30, 2012, 8:59 p.m.)
>
>
> Review request for accumulo.
>
>
> Description
> -------
>
> A patch for adding quoting to column visibility
>
>
> Diffs
> -----
>
>   /trunk/core/src/main/java/org/apache/accumulo/core/security/Authorizations.java 1379035
>   /trunk/core/src/main/java/org/apache/accumulo/core/security/ColumnVisibility.java 1379035
>   /trunk/core/src/main/java/org/apache/accumulo/core/security/VisibilityEvaluator.java 1379035
>   /trunk/core/src/test/java/org/apache/accumulo/core/security/ColumnVisibilityTest.java 1379035
>   /trunk/core/src/test/java/org/apache/accumulo/core/security/VisibilityEvaluatorTest.java 1379035
>
> Diff: https://reviews.apache.org/r/6861/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> kturner
>
>

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6861/#review10917
-----------------------------------------------------------

/trunk/core/src/main/java/org/apache/accumulo/core/security/Authorizations.java
<https://reviews.apache.org/r/6861/#comment23449>

    In some cases, the loss of this check, may result in some typos in the authorization to pass through, instead of failing early. I don't see that this is too big of a problem, though. All characters are now valid in authorization tokens.

/trunk/core/src/main/java/org/apache/accumulo/core/security/ColumnVisibility.java
<https://reviews.apache.org/r/6861/#comment23450>

    I strongly recommend using the double-quote, if you're going to allow quoting. As demonstrated in this comment alone, the single quote has multiple purposes. You'll probably get less conflict if you rely on double-quote as the quote character.
- Christopher Tubbs
On Aug. 30, 2012, 8:59 p.m., kturner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6861/
> -----------------------------------------------------------
>
> (Updated Aug. 30, 2012, 8:59 p.m.)
>
>
> Review request for accumulo.
>
>
> Description
> -------
>
> A patch for adding quoting to column visibility
>
>
> Diffs
> -----
>
>   /trunk/core/src/main/java/org/apache/accumulo/core/security/Authorizations.java 1379035
>   /trunk/core/src/main/java/org/apache/accumulo/core/security/ColumnVisibility.java 1379035
>   /trunk/core/src/main/java/org/apache/accumulo/core/security/VisibilityEvaluator.java 1379035
>   /trunk/core/src/test/java/org/apache/accumulo/core/security/ColumnVisibilityTest.java 1379035
>   /trunk/core/src/test/java/org/apache/accumulo/core/security/VisibilityEvaluatorTest.java 1379035
>
> Diff: https://reviews.apache.org/r/6861/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> kturner
>
>

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6861/#review10920
-----------------------------------------------------------

/trunk/core/src/main/java/org/apache/accumulo/core/security/ColumnVisibility.java
<https://reviews.apache.org/r/6861/#comment23454>

    JavaDoc should be updated to reflect the new changes.

/trunk/core/src/test/java/org/apache/accumulo/core/security/ColumnVisibilityTest.java
<https://reviews.apache.org/r/6861/#comment23456>

    Can you add another test that checks quotes + parenthesis?

/trunk/core/src/test/java/org/apache/accumulo/core/security/VisibilityEvaluatorTest.java
<https://reviews.apache.org/r/6861/#comment23455>

    Catch VisibilityParseException?
- Mike Drob
On Aug. 30, 2012, 8:59 p.m., kturner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6861/
> -----------------------------------------------------------
>
> (Updated Aug. 30, 2012, 8:59 p.m.)
>
>
> Review request for accumulo.
>
>
> Description
> -------
>
> A patch for adding quoting to column visibility
>
>
> Diffs
> -----
>
>   /trunk/core/src/main/java/org/apache/accumulo/core/security/Authorizations.java 1379035
>   /trunk/core/src/main/java/org/apache/accumulo/core/security/ColumnVisibility.java 1379035
>   /trunk/core/src/main/java/org/apache/accumulo/core/security/VisibilityEvaluator.java 1379035
>   /trunk/core/src/test/java/org/apache/accumulo/core/security/ColumnVisibilityTest.java 1379035
>   /trunk/core/src/test/java/org/apache/accumulo/core/security/VisibilityEvaluatorTest.java 1379035
>
> Diff: https://reviews.apache.org/r/6861/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> kturner
>
>

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6861/
-----------------------------------------------------------

(Updated Aug. 31, 2012, 4:14 p.m.)
Review request for accumulo.
Changes
-------

* Escaped auths instead of unescaping terms in visibility
* Used " instead of ' for quoting
* Added static quote() helper function
* updated javadoc
* fixed issues in unit tests
Description
-------

A patch for adding quoting to column visibility
Diffs (updated)
-----

  /trunk/core/src/main/java/org/apache/accumulo/core/security/Authorizations.java 1379492
  /trunk/core/src/main/java/org/apache/accumulo/core/security/ColumnVisibility.java 1379492
  /trunk/core/src/main/java/org/apache/accumulo/core/security/VisibilityEvaluator.java 1379492
  /trunk/core/src/test/java/org/apache/accumulo/core/security/ColumnVisibilityTest.java 1379492
  /trunk/core/src/test/java/org/apache/accumulo/core/security/VisibilityEvaluatorTest.java 1379492

Diff: https://reviews.apache.org/r/6861/diff/
Testing
-------
Thanks,

kturner

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6861/
-----------------------------------------------------------

(Updated Aug. 31, 2012, 4:20 p.m.)
Review request for accumulo.
Description
-------

A patch for adding quoting to column visibility
This addresses bug ACCUMULO-241.
    https://issues.apache.org/jira/browse/ACCUMULO-241
Diffs
-----

  /trunk/core/src/main/java/org/apache/accumulo/core/security/Authorizations.java 1379492
  /trunk/core/src/main/java/org/apache/accumulo/core/security/ColumnVisibility.java 1379492
  /trunk/core/src/main/java/org/apache/accumulo/core/security/VisibilityEvaluator.java 1379492
  /trunk/core/src/test/java/org/apache/accumulo/core/security/ColumnVisibilityTest.java 1379492
  /trunk/core/src/test/java/org/apache/accumulo/core/security/VisibilityEvaluatorTest.java 1379492

Diff: https://reviews.apache.org/r/6861/diff/
Testing
-------
Thanks,

kturner